dylmye / lets-plan Goto Github PK

Summary

Using the signup feature "sign up with google" causes firebase auth handler to freeze, sign in works as intended

Reproduction

1. Visit lets plan fresh (no previous account)
2. Click user menu > sign up
3. Select Google

Expected

Just like with signing in, the auth popup closes and the user is brought back to their account where they are now logged in

Actual

The auth popup shows for an extended period before closing with an error: "Popup closed before sign up could complete".

Note that this doesn't happen for Google accounts that already have an account on Lets Plan, and doesn't happen at all when using "sign in with google" even for account new to Lets Plan

Summary

Loading a trip that is public while not logged in results in the user temporarily seeing trip not found when a loading screen should be in place

Reproduction

1. Create a trip logged in
2. Set it to public
3. In a different browser or incognito open the trip URL

Expected

Loading state while the trip is loading, then trip is visible

Actual

Loading state + trip not found message, then trip is visible

Summary

Migrating trips to an account creates a duplicate with no items

Reproduction

1. Fresh session of Lets Plan
2. Create a trip (locally)
3. Create an account
4. Account migration process of existing trips

Expected

Trips copy over exactly, with image, trip items.

Actual

Two trips are made, one with the trip items, one with none

When you're on poor quality data connection (think stadiums, underground parking etc) loading can take forever. There are legitimate situations users can be in, like aeroports with shoddy wifi, where this can be a burden. We should shorten the timeout for Firebase to improve this. If Firebase can't fetch latest can we show a message?

See migration guide here: https://mui.com/x/migration/migration-pickers-v5/
We exclusively use this component through formik-mui but this package hasn't been updated to support this version yet.

Summary

App freezes when attempting to edit trip details or a trip item

Reproduction

1. Create a trip Lets Plan
2. Attempt to edit it

For trip items

1. Create a trip in Lets Plan
2. Add an item
3. Attempt to edit it

Expected

Dialog shows with form fields entered and able to change these values

Actual

App freezes, becomes unresponsive for > 1 min

Current issues:

• In tz behind UTC, starts at date on trip details shows the day before
• In tz behind UTC, item ends at validation is off by tz offset meaning if you are in -4 then any events past 20:00 are invalid
• Creating a trip item makes the starts at/ends at on said item off, editing it works correctly behind UTC but ahead of UTC you have to subtract the offset when you set it to a different day (so to make an event at 6pm in +1 you have to set it at 5pm)
• The countdown on trip list doesnt account for timezone
• In tz ahead of UTC, starts at + ends at dates on trip details shows the day before, editing it works correctly

Summary

Clicking the "reload" button on the service worker update prompt doesn't refresh the page, meaning users have to manually refresh to use the latest version after clicking it

Reproduction

1. Have an out of date version of LP
2. Click "reload" on the update prompt

Expected

• Browser refreshes
• New version commit hash is visible on menu

Actual

• Browser doesn't refresh
• Old version commit hash is visible on menu

See migration guide here: jquense/yup#1906

Breaking change requires accept param to be an object now. https://github.com/react-dropzone/react-dropzone/releases/tag/v13.0.0

Required for Google Play

Summary

Unset the new trip form's "ends at" date field, to allow users to select any starts at date

Details

A current point that users find difficult is that by default they fill form steps top to bottom. The step where you define when the trip starts and ends commonly causes issues. The default values for these fields are today and today + 7 days. (The value of these default field values are contentious other than for showing that the field's data type is a date, but that's beside the point.)

The end date validation means that when the user goes to set the start date of a trip, they are limited to any date within 7 days. They then have to go and clear / set the end date in order to set the start date.

Proposing either to not set either field by default, or just set the start date to today and don't set the end date

Who would benefit from this?

All users creating trips

Please check the following

• If this feature is implemented, I won't be compensated for it and I don't own any rights or stake in the feature
• I've checked the other feature proposals and nobody has posted this already

Summary

Colour of activity/travel cards on add your plans view are the same colour as the background in light mode

Reproduction

1. Create a trip on Lets Plan
2. At any time before adding items, switch to light mode

Expected

Cards are visible

Actual

Summary

Clicking the "+" button on a day header on mobile when the top of the day isn't visible leads to the form opening off-screen

Reproduction

1. Create a trip with multiple trip items on two or more days
2. On a mobile device in portrait or another restricted-width viewport, open the trip and scroll down so the day header is visible but not the firstmost trip item for said day
3. Press the "add to day" + button on the header

Expected

If the add to trip form isn't visible, the browser scrolls up to make it visible

Actual

The scrollbar becomes visible to show something has opened but the form is not visible, which may lead to confusion.