dylan-lang / dylan-programming-book Goto Github PK

angle library export direction without declaring it as an open generic function, in airport library, "direction" is used again as a slot of <aircraft>, these cause some serious warnings.

If you check in this section, you'll see below something like:

In other cases, there can be several applicable methods. Consider the generic function say-greeting, shown in The say-greeting generic function and its methods. :ref:applicable-methods-for-say-greeting shows that...

I believe the The say-greeting generic function and its methods part is supposed to be a ref to say-greeting-gf-methods.

I tried to write a patch for this, such as:

diff --git a/source/offset.rst b/source/offset.rst
index edecafa..00e813b 100644
--- a/source/offset.rst
+++ b/source/offset.rst
@@ -542,8 +542,7 @@ there is no applicable method, the “No applicable method” error is
 signaled. There is no need to continue to step 2.

 In other cases, there can be several applicable methods. Consider the
-generic function ``say-greeting``, shown in `The say-greeting generic
-function and its methods <say-greeting-gf-methods>`_.
+generic function ``say-greeting``, shown in :ref:`say-greeting-gf-methods`.
 :ref:`applicable-methods-for-say-greeting` shows that, for certain
 arguments, one method is applicable, but that, for an integer argument,
 two methods are applicable.

But it wasn't working..

If you could tell me what I'm doing wrong, or how to fix this patch I'd love to fix it, and any other doc bugs I run into with Dylan!

If you check this section it mentions defining a variable *8-30-59* like so:

define variable *8-30-59* = make(<time-of-day>, total-seconds: encode-total-seconds(8, 30, 59));

However, I think variable names must start with a non-number because I get a warning when trying this example.

I should also note I'm using Open Dylan 2013.1

Would you accept a patch to fix this and use a valid variable name?