Allow extension (merging) of keybidings about proton HOT 6 CLOSED

Hi,

  {:t {:category "toggles"}
     :p {:category "pomodoro"
         :s {:action "pomodoro:start"
             :title "Start Timer"}
         :a {:action "pomodoro:abort"
             :title "Abort Timer"}}})

here you are just overwriting the :t key: :t {:category "toggles"} (the :t map is closed). I think you have a little bracket misplacement.

Nevertheless, code in question is here. Looks like I misunderstood what merge does. Need to apply a recursive merge here that goes into sub-maps

from proton.

Found some deep-merge implementations and added them as helpers here. Didn't have time yet to check deep-merging of keybindings

from proton.

So the deep merge seems to work.

How could I extend the :t map (i.e. what did you mean by "it is closed")?

from proton.

I mean, you want :p inside :t, don't you? So :p should be a element of the map thats assigned to :t.

In your example you define 2 root keys: :t and :p.

{:t {:category "toggles"}
   :p {:category "pomodoro"
       :s {:action "pomodoro:start"
           :title "Start Timer"}
       :a {:action "pomodoro:abort"
           :title "Abort Timer"}}}

It should be

{:t {:category "toggles"
     :p {:category "pomodoro"
         :s {:action "pomodoro:start"
             :title "Start Timer"}
         :a {:action "pomodoro:abort"
             :title "Abort Timer"}}}}

now :p is inside :t and the chain would be t -> p -> s for pomodoro start

from proton.

🤦 oh man that was a dumb mistake. Parifiner is cool, but I'm going to have to get used to it adding brackets in places.

Anyway, this is closed by #28

from proton.

Haha that's what I thought :)

You technically never really have to touch your brackets with Parinfer. Just indent it so the :p aligns with :category and it will change the brackets for you.

from proton.