dusty-phillips / rescript-zora Goto Github PK

Thanks for creating the bindings for Zora, it's quite a nice testing suite for rescript!

Sometimes you don't want to write a test message for an assertion, would you be open to a PR that would change the current API to make the test message optional?

It would be a lightweight layer like this:

let equal = (~msg=?, t, act, exp) => equal(t, act, exp, msg) 

You would use it like that:

t->equal("foo", "foo")
// or if you do want a description
t->equal("foo", "foo", ~msg="those two strings should be the same")

Sure it adds a some runtime, but it'd be likely unnoticeable, especially for testing and it would sometimes help to make sure you're not feeding the text message with the expected string value.

Discussion here: test and update

2f4d744#r56349549

Trying to figure out why exposing Promise.catch in the rescript-zora library or even calling Promise.catch in my own code gives that es6 module error.

ryyppy/rescript-promise#15 (comment)

When I just run one test it works fine

I run the tests like this "test": "pta 'tests/*.test.mjs'",

tests/
- utils.test.res # generates utils.test.mjs and runs tests ok

but when I add normal test files to the mix, Zora only runs the non-rescript

tests/
- utils.test.res # generates utils.test.mjs and but is not run by Zora
- api-utils.test.mjs # run by zora
- other-utils.test.mjs # run by zora

Any idea what might I been missing?

Right now test is modeled like this:

@send external test: (t, testTitle, zoraTest) => unit = "test"

Shouldn't it be modeled like this instead:

@send external test: (t, testTitle, zoraTest) => Js.Promise.t<unit> = "test"

Otherwise you can write multiple tests in a Zora block, finish with a done() and get an error:

tried to collect an assertion after it has run to its completion.
You might have forgotten to wait for an asynchronous task to complete

What do you think?