dun-sin / smartsearch Goto Github PK

What would you like to share?

There are enough issue templates, which means no one should be able to add blank issues.

Do this by adding a config.yml file in .github folder

Additional information

No response

Description

I have seen their public API

`https://www.gsmarena.com/search-json.php3?sSearch=${input.value}`

so instead of running phones.js just use their API instead. This will improve server performance.
What do you think ??

Screenshots

No response

Description

Hi @Dun-sin. I found a few grammar errors in the first sentence of the Readme File (e.g. "Find phone details by searching for your faviourite phone brand e.g redmi, iphone, samsung"). Can I make those changes? It'll make the Docs more comprehensible.

Screenshots

No response

Description

Cannot find the license file in the project.

Screenshots

No response

Description

Users should be able to filter the type of phones they want under the brand like the price, ram size, storage, camera of phones they want

Screenshots

No response

Description

Contributing.md file should cover details on how to contribute to this project

use this as a demo

Screenshots

No response

Description

Building on #16, adding functionality will be based on the back-end, but it means more features of the phone needs to be available on searching and not when the phone is clicked.

Screenshots

No response

Description

there is a spelling error in the contributing.md file in the contributing guidelines rules section specifically the third rule

Screenshots

No response

Description

Use semantic release and commitizen to automate release

Screenshots

No response

Description

• The Image looks streched more than it should have been. ( Take a look at Image 1)
• The texts are also too close to each other and provides an overall bad UI/UX for the mobile view

Fixes ?

• i would like to make the picture in a much more contain manner.
• Also some increased margin/padding for the texts !

Screenshots

Image 1

Description

Readme.md file is needed to describe the project and give instructions and how to contribute, including the technologies used

use this as a guide

Screenshots

No response

Description

There is a section for phone reviews and Right now it just shows a default text of "oops, no one is talking about this phone"

Get the reviews of a phone from GSM or another site that shows phone reviews in text format

Screenshots

Description

The review section seems complicated even tho it works, the conversation takes everything from the reply to the quote reply and add it in one box with no clear differerence between them

Screenshots

No response