duffelhq / duffel-api-java Goto Github PK

Documented coordinates-

<dependency>
  <groupId>com.duffel</groupId>
  <artifactId>api</artifactId>
  <version>1.1.2</version>
</dependency>

Correct coordinates -

<dependency>
  <groupId>com.duffel</groupId>
  <artifactId>duffel-api</artifactId>
  <version>1.1.9</version>
</dependency>

Wrong link - https://github.com/duffelhq/duffel-api-java/blob/main/examples/search_and_book.java

I think Correct link may be - https://github.com/duffelhq/duffel-api-java/blob/main/src/test/java/com/duffel/example/SearchAndBookIT.java

When I use duffelApi.offerRequestService create an offer request, I want to set param "return_offers" false , how can I do?

I don't see gzip compression enabled for responses. Also recommended in docs

According to the docs default maxConnections is 1 but in the code we are using int (primitive)

So, if a client does not set this it would be set to 0 and that would make the default to 0 - Direct flight, which would be different than what the doc says.

Can we use Java documentation comments (/** ... */) instead of

///  <summary>
///  A machine-readable identifier for this specific error
///  </summary>

So the information is available in the IDE and also for doc generation tools.

Hi,

After implementing the SDK we realized that the amount of offers and fares makes difficult to get all the data sorted in an usuable way. We read about the Partial offers on the API and we see it more suitable to our needs, nevertheless we dont see how to implement directly from the java sdk.

Could you share with us if partial offers are possible in the sdk or have to be implemented using API calls.

Thanks

Regards

Is there a service in the client with the implementation of the places suggestions endpoint?

https://duffel.com/docs/api/v1/places/schema

GET https://api.duffel.com/places/suggestions