duckyuck / flare Goto Github PK

When printing clojure.test failures flare is mixing up the expected and actual result. Below are two example tests. The second one is from the clojure.test documentation.

(deftest example
  (is (= "expected" "actual")))

(deftest documentation-example
  (is (= 5 (+ 2 2))))

Output

FAIL in (documentation-example) (sql_gen_test.clj:365)
expected: (= 5 (+ 2 2))
  actual: (not (=== 5 4))

expected 4, was 5

FAIL in (example) (sql_gen_test.clj:362)
expected: (= "expected" "actual")
  actual: (not (=== "expected" "actual"))

strings have 1 difference (0% similarity)
expected: "(actual--)"
actual:   "(expected)"

My expectation based on the clojure.test documentation is that the first argument to = is the expected output.

flare.core=> (diff '[1 2 3] '[1 2 3 4])
nil
flare.core=> (diff-sequential '[1 2 3] '[1 2 3 4])
nil

This means that diff used to describe output of failing Midje or clojure.test tests has nothing to say about some differing sequentials. Is that intentional?