Comments (4)
Hey! I wrote extensive messages for those changes in the following commits:
- Commit where I removed the option: a44530c
- Commit where I rewrote the partial update system: 4396bb7
Let me know if you have questions!
from retro-go.
Hi! Thank you for your answer. I haven't yet read the code, but your comments are clear. I understand the reasons of the change.
And keeping the option adding your new screen update as a possible choice doesn't make sense? Someting like "Partial v2"
from retro-go.
And keeping the option adding your new screen update as a possible choice doesn't make sense? Someting like "Partial v2"
I don't think it's worth having an option because the new code "just works". The hashing adds some overhead (on core 1, which is underutilised) but I've done extensive measuring and I haven't found any instance where partial code was slower than always doing full frame. I've also tested all combinations of scaling and filtering and the image is identical with or without partial enabled.
There is a measurement in the debug menu called "Blit time". For comparison a full update takes ~32-36ms to send to the screen. So, as long as that number is less than that, it means that partial frame is helping or at least not hindering.
So at this point an option wouldn't benefit the user and it would waste my time because on every change I make I'd have to test partial+filtering1, full+filtering1, partial+filtering2, full+filtering2, partial, full, partial+scaling+filtering, full+scaling+filtering, etc.
All that being said! if you truly don't want partial, I can add a #define
in the target file to disable it at compile time :)
from retro-go.
No no you're right it would be a waste of time. I close this issue, it was just by curiosity. Your new implementation of screen update works fine
from retro-go.
Related Issues (20)
- [Feature] - ST7701S SPI LCD Driver HOT 3
- Files with too long a name do not show in launcher and/or are corrupted in the web UI. HOT 2
- Building for a custom board HOT 1
- Numerical Battery Readout in Debug HOT 4
- Question about reading sd card HOT 14
- MRGC and Gamebox battery voltage HOT 3
- PocketSprite support
- Does this filmware work with esp32-s3? HOT 5
- Game Boy Advance Emulator HOT 4
- PSRAM Required? or is there a way to build an image for running on a ESP32-wroom-32? HOT 5
- Problem to run / build on esp32s3 HOT 13
- On develop branch reset init lcd screen missing HOT 5
- Blinking screen in launcher HOT 19
- PC Engine - Raiden Crashes when setting palette. HOT 6
- Support ZX-Spectrum HOT 3
- Add support for Neo Geo Pocket (Color) HOT 1
- Prboom(esp32-s3): External DAC crashes when system monitor task is enabled. HOT 14
- Requirements not satisfying when trying to build img for esp32s3 HOT 5
- panic with some roms HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from retro-go.