dubstar-04 / feedsandspeeds Goto Github PK

While testing FC pull request FreeCAD/FreeCAD#4387, found the Addon menu text sometimes goes blank. mlampert has suggested this might be an issue with this addon. I was thinking it might have been an issue with the other features being en/disable through that pull request.

My original issue notes:
Path - Path Addons menu text is sometimes blank ...ie there is an empty/blank as frist item below menu seperator. Note in this FC config, I have dubstar-04 Feeds and Speeds addon installed https://github.com/dubstar-04/FeedsAndSpeeds. Hovering over the blank menu position, does cause the flyout menu to appear with the Feeds and Speeds addon shown.

Used path pref, to disable experimental features, saved, restarted FC and menu line blank again, and captured image, attached.
Can mostly replicate without restarting FC, just by toggling Path pref, exp features on/off. Mostly means start FC & load APath WB. Check path menu (usually correct), toggle the pref and menu item text goes blank. Toggle exp pref again (always with an OK to save) and the menu text may or may not change... I have not go to the bottom of the behaviour. eg I have seen the menu text blank survive a FC close/repopen (ie not present both before closing and still not present on reopening/restarting FC).

It would interesting to have a persistent setting indicating the spindle's maximum speed.
This value can then be used in calculating the feed speed accordingly.

While scripting with your great addon, I noticed that overrides of rpm where being ignored in returned rpm.

Cause seems to be return variable is "rpm", but "calc_rpm" is used if rpm override is triggered and also used for all the calculations, but then "rpm" is used in the return.

I have not submitted pull request, as I feel which way fix is implemented might be more a matter of personal taste, but happy to submit if your prefer.

when starting the Feeds and Speeds Addon, the diameter value is exactly 10 times higher, than specified in the ToolController.

OS: Windows 10 Version 1909
Word size of FreeCAD: 64-bit
Version: 0.20.25306 (Git)
Build type: Release
Branch: master
Hash: 5f5b3d9b67136edda1f6738f1a83154990f7839d
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.0
Locale: German/Germany (de_DE)

Also tested with the stable release of FreeCAD 0.19 -> same issue

Would be nice to see the surface speed of the cutter with its unit in the output section.
This is especially handy if you overwrite your spindle speed manually to get a plain number or because you have to use a certain speed to avoid resonances of your machine. In this case an additional information of the surface speed of the cutter would be handy.

I think that the power calculation should stop increasing when you exceed a stepover greater than the tool diameter.

https://forum.freecadweb.org/viewtopic.php?f=15&t=65738&p=565964#p565951

Rationalize the data passed to the feed and speed lib and add test to run on each PR.

Opened a test document I created late 2020 & FS calc output:

18:43:32 Traceback (most recent call last):
File "C:/Users/spanner888/AppData/Roaming/FreeCAD/Macro/FS_open.FCMacro", line 3, in
PathFeedsAndSpeedsGui.Show()
File "C:\Users\spanner888\AppData\Roaming\FreeCAD\Mod\fsMaster\PathFeedsAndSpeedsGui.py", line 186, in Show
panel = FeedSpeedPanel()
File "C:\Users\spanner888\AppData\Roaming\FreeCAD\Mod\fsMaster\PathFeedsAndSpeedsGui.py", line 24, in init
self.setup_ui()
File "C:\Users\spanner888\AppData\Roaming\FreeCAD\Mod\fsMaster\PathFeedsAndSpeedsGui.py", line 57, in setup_ui
self.load_tool_properties()
File "C:\Users\spanner888\AppData\Roaming\FreeCAD\Mod\fsMaster\PathFeedsAndSpeedsGui.py", line 97, in load_tool_properties
flutes = tool.Flutes
<class 'AttributeError'>: 'FeaturePython' object has no attribute 'Flutes'

I have a vague memory that this may have been a late addition in new ToolBits system. Regardless other users may run into this as well.

Handle legacy tools better. Consider greying out the entry in the drop-down or similar to indicate it's not supported.

Hi, when manually setting the spindle speed in the dialog, it seems to get saved as 10x too high, see below;

Add icons or "save" text and include a popup to check the user wants to write the data to the TC

Provide a visual warning to users for potentially problematic results.

Consider assigning a material to the stock element.

• handle multiple jobs?
• where to store the material element?

This might be related to the re-work of the Materials system, but wanted to log it in case you hadn't seen it:

20:17:34  Traceback (most recent call last):
20:17:34    File "/home/osh/.local/share/FreeCAD/Mod/FeedsAndSpeeds/./PathFeedsAndSpeedsGui.py", line 290, in Show
20:17:34      panel = FeedSpeedPanel()
20:17:35    File "/home/osh/.local/share/FreeCAD/Mod/FeedsAndSpeeds/./PathFeedsAndSpeedsGui.py", line 35, in __init__
20:17:35      self.load_materials()
20:17:35    File "/home/osh/.local/share/FreeCAD/Mod/FeedsAndSpeeds/./PathFeedsAndSpeedsGui.py", line 79, in load_materials
20:17:35      material_card = read(os.path.join(material_dir, file))
20:17:35    File "/tmp/.mount_FreeCAen6314/usr/Mod/Material/importFCMat.py", line 103, in read
20:17:35      material = materialManager.getMaterialByPath(filename)
20:17:35  LookupError: Material not found

This happens on both macOS Sonoma and Debian Bookworm. Debian details below:

OS: Debian GNU/Linux 12 (bookworm) (GNOME/gnome)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.35456 (Git) AppImage
Build type: Release
Branch: main
Hash: c91a35961f7ef42f1b64eb11ca963d6fbc0b42da
Python 3.10.13, Qt 5.15.8, Coin 4.0.2, Vtk 9.2.6, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * FeedsAndSpeeds 0.5.0

If in FC the ToolController Toolbit Flutes is 0, GUI opens showing value of "1". Similarly Chipload shows 0.020 when TC.Tool.Chipload = 0.

Edit: If number flutes=0, then will hfeed=0, so maybe should be set to 1, or ask user.

The chipload issue has been staring me in the face for long time, as there is already a print showing that.

To reproduce: Create a new doc, new part cube, cut a cylinder, new job using cut, without using template and without using any existing tools. Only using default TC/TB. examine TC & TB props in FC path and values shown in FS calc.

input allows negative stepover, stepdown and surface speed.

Hello,

The "chipload" and "surface speed" inputs are currently not labelled with units.

The labels for those inputs should mention what units they are. I suspect it's mm/tooth for the chipload, and napkin math says it's meters/minute for the surface speed, at least for my FreeCAD settings, but the user shouldn't be guessing this critical information – confusion and uncertainty increases the risk for newbies to damage their equipment.

Add units for spindle speed

Show an icon in the combobox to indicate if tools have feeds and speeds set.