duaraghav8 / soltar Goto Github PK

Possible enhancement:
Update Literal to handle Objects as well (since regex returns {})
when using regex, solidity-parser sets the Literal object's value to {}. Bug on SP side??

Hi @duaraghav8 , when I was looking up for AST to Solidity tools/libraries, soltar happens to be the first and the only result. As what it looks like, it doesn't support many new features of newer version of Solidity. Do you plan to add the support?

Thanks! :)

if (a && (b || (!c))) { foo (); }

the AST for the above, when passed to soltar.generate (), generates the following:

if (a && b || !c) {\n\tfoo ();\n}

Another example

(89 * 2) - (12 + (34 / (y**2))) + (23 % (2**2))

output:

89 * 2 - 12 + 34 / y ** 2 + 23 % 2 ** 2;

there should be brackets :'(

in the Type node:

{ type: 'Type', literal: 'address', members: [], array_parts: [ 5 ] };

what the fuck is members: [] for??

solidity-parser generates following representation of Hex Values:

{type: "Literal", value: '0x89'}

Need safe way to distinguish Hex values from typical strings (can't simply make a check for '0x' prefix, this can be part of a normal string also)

life is just unfair :'-(

New features are being added and the developers of solidity-parser are working hard at implementing the all in their Abstract Syntax tree. Keep up

List of (unfixed) bugs in solidity-parser

1. No support for RegExp - the literal object's value gets set to {}, eg -
   {type: "Literal", value: {}}
2. No 'name' field in StructDeclaration - this means we never get to know the name of the struct from the StructDeclaration Node object. (I've made a PR for this)
3. IsStatement malfunctioning - When using inheritance with Contract or Library, the syntax is:

contract Car is Vehicle, Engine {
        //definition
}

Solidity parser doesn't parse the 'is' section properly. the is Array's first object is fine (vehicle), but subsequent element is just a comma, not another object for Engine.

1. Exponentiation operator (double asterisk) not being parsed by solidity parser
2. A statement like uint x = 2 days; doesn't get parsed. It gives error at start of 'days'.
3. Parse of var (x) = 100; failing because x is surrounded by brackets (which is legal in solidity).

var (x, y) = (10, 20);
is the correct syntax, not
var x, y = (10, 20);

fix

• Demo on gh-pages
• Add Command-line utility
• Write tests & set up coverage info
• Minify soltar-bundle.js
• browser compatibility
• Inform of currently un-patched bug in StructDeclaration in solidity-parser and in IsStatement

I'm trying to set this up, using the AST generated from solparse with this file, but I get the following error:

/Users/danielque/git/cryptofin-solidity/node_modules/soltar/index.js:342
                                        GENERATOR_OBJECT [item.type] (item),
                                                                     ^

TypeError: GENERATOR_OBJECT[item.type] is not a function
    at /Users/danielque/git/cryptofin-solidity/node_modules/soltar/index.js:342:35
    at Array.forEach (<anonymous>)
    at CodeGenerator.ContractStatement (/Users/danielque/git/cryptofin-solidity/node_modules/soltar/index.js:339:14)
    at /Users/danielque/git/cryptofin-solidity/node_modules/soltar/index.js:830:34
    at Array.forEach (<anonymous>)
    at CodeGenerator.Program (/Users/danielque/git/cryptofin-solidity/node_modules/soltar/index.js:825:13)
    at CodeGenerator.generateStatement (/Users/danielque/git/cryptofin-solidity/node_modules/soltar/index.js:219:26)
    at CodeGenerator.generate (/Users/danielque/git/cryptofin-solidity/node_modules/soltar/index.js:228:15)
    at Object.generate (/Users/danielque/git/cryptofin-solidity/node_modules/soltar/index.js:1474:4)
    at Object.<anonymous> (/Users/danielque/git/cryptofin-solidity/test.js:105:31)

Without being familiar with the code, this is perhaps caused by lack of support for these?

• PragmaStatement
• LibraryStatement
• ModifierArgument