dsrkafuu / skyline-overlay Goto Github PK

Is your feature request related to a problem? Please describe.
I wouldn't say a "problem", but it would be easier to select a specific encounter (1st boss of dungeon, 2nd boss of dungeon, etc) if the encounter history used the encounter name displayed in ACT.

Describe the solution you'd like
I would like the encounter history to show encounter name, not zone name.

Describe alternatives you've considered
There's not really an alternative for this request, as it's a very specific request.

Additional context
So for example, instead of "The Goblet", it would say "Striking Dummy".

能否在底部显示增加伤害占比%、死亡次数，在数据条显示伤害占比和治疗占比的选项，谢谢
Could you add Damage% and Deathcount options at bottom display. And add tickers of Damage% and Healing%, thank you.

Describe the bug
A clear and concise description of what the bug is.
When I check the history for the fights in the overlay, if I select one it automatically moves back to the previous pull not allowing me to check the other fighrts in the history
To Reproduce
Steps to reproduce the behavior:

1. Go into a encounter
2. Do 2 pulls to have 2 logs in your history
3. Select the 2nd pull in the history
4. It will automatically go back to the last pull in the history

Expected behavior
It is supposed to allow me to check the history of previous pulls
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Gif of the issue occuring
https://imgur.com/VfLxw0y

The ikegami theme only shows the selected setting whilst hovering, once selected both options turn grey again.

Skyline Theme Settings:

Ikegami Theme Settings:

Ikegami whilst hovering setting:

Would it be possible for you to add a option to have your own DPS highlighted, in a color specified in the themes file?
Kind of like Horizoverlay shows your own DPS in white.

Also maybe the option to display HPS, again like in Horizoverlay.

Loving the overlay so far.

• Add a feature to blur out usernames, like commonly found in other overlays
• Add the option to put different colors for each job

If it's not too complicated (and not possible yet) add the option to have custom css within a theme file, so you can use filters on the job icons (greyscale, sepia) or use gradient colors as backgrounds for example.

Would be nice to be able to have, on one of the columns, DPS and 1m DPS, that show your DPS from the last minute/2 minutes, that way, you can check if your rotation is correct.

Add a players per row feature such that when a player count exceeds the row limit, it starts a new one.

Alternatively, set a row and column limit or even a hard coded 4x2 version of the meter.

Not sure if I'm just using it wrong, but the Websocket Overlay doesn't seem to work.

For Horizoverlay and Kagerou I added /?HOST_PORT=ws://127.0.0.1:10501/ behind the provided URL of the overlay, which worked, when trying to use https://skyline.dsrkafuu.su/?HOST_PORT=ws://127.0.0.1:10501/ the overlay isn't working inside my browser.

Tried different browsers

In the screenshot I used 2 browser tabs with the following urls:
https://skyline.dsrkafuu.su/?HOST_PORT=ws://127.0.0.1:10501/
https://github.com/bsides/horizoverlay/?HOST_PORT=ws://127.0.0.1:10501/

Horizoverlay was working inside the browser, whilst Skyline-Overlay wasn't.

Describe the bug
critical and direct hits shown on the bottom are reversed.

To Reproduce
Steps to reproduce the behavior:

1. Attack the dummy.
2. Measure DPS
3. Check the critical and direct hit values
4. Critical and direct hit percentages are displayed backwards.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

When I try to enable I get the following error

[18/01/2022 03:56:21] Info: SkylineOverlay: BrowserConsole: Uncaught TypeError: Cannot read properties of undefined (reading 'translation') (Source: https://skyline.dsrkafuu.net/assets/index.1522fa93.js, Line: 1)

The overlay crashes when clicking on the "General" tab in settings with the following error:

"Skyline Overlay: BrowserConsole: Uncaught TypeError: Cannot read property 'text' of undefined (Source: https://skyline.dsrkafuu.su/assets/vendor.dc2dac6f.js, Line: 27)"

Any pics before downloading?

Describe the bug
Colors are not reflected when JRound theme is used.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. DPS for you and your PT members will be displayed in black

Expected behavior
I would like the colors to reflect the colors that were on v3.6.0.

Hi!

Thanks for your well-known wonderful overlay!

We (@thewakingsands, aka FFCafe) are mirroring skyline for users in china mainland, located at:

https://overlays.ffcafe.cn/skyline/

This is a slightly modified version forked at https://github.com/ffcafe-overlays/skyline-overlay/tree/cn .

We distributed it under Apache 2.0 license, however, we think it's better to let you know we are hosting it, and if you have any questions about that or want us to take down it, contact me on GitHub or email/discord and we will take actions immediately.

There aren't any actions other than closing this issue that needed to be taken if you think it's fine.

Thank you for your great work again!

The picture preview shows the highest damage on the left moving to the lowest on the right, mine is right to left instead. How can I fix this?

Thank you!

Unable to change input value in ACT Overlay
When the user tries to change the input value in the overlay, all key inputs are invalid

• Bug description
  I think the damage number display is incorrect when you choose the big number mode in Chinese version. It confuses one thousand (1000) with ten thousand (10000).

• Steps to reproduce the bug

1. Go to 'data'
2. Click on 'Big data mode'
3. See error

• Expected behavior
  A clear and concise description of what you expected to happen.

• Screenshots
  Correct in normal mode
  
  Incorrect in big number mode
  

the name of trial/raid sometimes is too long and overlapped with the dps meter, would be great if i can hide the name
https://imgur.com/a/lOFlZ3Z

Describe the bug
When attempting to view previous encounters using the encounter history feature, the history will revert to the most recent encounter within 1 second. This is due to the current time of day display updating. As there is little reason to have such a display, simply removing it will likely fix the issue.

To Reproduce
Steps to reproduce the behavior:

1. Click settings cog wheel.
2. Click the History tab.
3. Click on a previous encounter in the list.
4. Watch as it reverts to the most recent counter the moment the time of day display advances by 1 second.

Expected behavior
Would expect clicking on a previous encounter would allow viewing of that encounter's results.

Screenshots

The 1.8.2 update of the overlay broke the self highlight feature, your own dps now stays the color of the role you are playing.

Describe the bug
When you click on a text input field (tested "Pet Merging ID", "Custom ID"), the entire overlay freezes and stops responding to any input.

To Reproduce
Steps to reproduce the behavior:

1. Click ⚙️ icon
2. Go to Display tab
3. Click on the "Custom ID" field (default value "YOU")
4. Everything freezes

Expected behavior
Text to be editable

Additional context
When this happens, most of the controls in the OverlayPlugin work either. Toggling "Force white background" does nothing, as does clicking "Reload overlay"; but toggling "Enable overlay" off and on again does reload the overlay. The likely reason is an infinite loop in the javascript that locks the UI thread.

I'm looking into this overlay, as I've used Horizoverlay for a while now and this one was brought to my attention. However, I'm trying to set it up and it's not necessarily easy to tell what each setting does or looks like.

My suggestion is to have a "setup mode" like Horizoverlay does, where some sample data is provided to the overlay so I can see the effects of the changes I make in real time, without having to get in combat. It's possible one exists - I'm still exploring the interface - but if it does I cannot locate it.

Thanks!