dsha256 / plfa Goto Github PK

Problem

RunAndListenClient: multiple goroutines across multiple runs of RunAndListenClient are reading from the “done” channel, and which one will receive something from that channel – completely random. As a result, in case of a lost connection, some random goroutine will exit and its graceful shutdown functionality will be lost.

---

Solution

To avoid such problems, the code should be simple. It’s hard to figure out how this method works because of multiple goroutines
and channels, thus it’s more error-prone. The easier the code, the harder a bug to find a place to hide. This functionality across all the methods and their goroutines can be done with a single context passed from the main. All the goroutines will read from ctx.Done() in select to shutdown gracefully.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update alpine docker tag to v3.20
• fix(deps): update module github.com/stretchr/testify to v1.9.0
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update module github.com/felixge/httpsnoop to v1.0.4
• fix(deps): update module github.com/gorilla/websocket to v1.5.3
• fix(deps): update module github.com/swaggo/http-swagger/v2 to v2.0.2
• fix(deps): update module github.com/swaggo/swag to v1.16.3
• chore(deps): update golang docker tag to v1.22
• fix(deps): update module github.com/spf13/viper to v1.19.0
• fix(deps): update module golang.org/x/time to v0.6.0
• chore(deps): update actions/checkout action to v4
• chore(deps): update actions/setup-go action to v5
• chore(deps): update dependency ubuntu to v22
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

docker-compose

docker-compose.yml

dockerfile

Dockerfile

• golang 1.20-alpine
• alpine 3.18

github-actions

.github/workflows/audit.yml

• actions/checkout v3
• actions/setup-go v4
• ubuntu 20.04

gomod

go.mod

• go 1.20
• github.com/felixge/httpsnoop v1.0.3
• github.com/golang/mock v1.6.0
• github.com/gorilla/websocket v1.5.0
• github.com/julienschmidt/httprouter v1.3.0
• github.com/pusher/pusher-http-go/v5 v5.1.1
• github.com/spf13/viper v1.15.0
• github.com/stretchr/testify v1.8.4
• github.com/swaggo/http-swagger/v2 v2.0.1
• github.com/swaggo/swag v1.16.1
• golang.org/x/time v0.3.0

---

• Check this box to trigger a request for Renovate to run again on this repository

Problem

The env file is baked into the image. It’s an arguable topic, but here’s my other opinion: such an approach is ok when a configuration file changes the app’s logic, and the config itself is changed rarely. For example PostgreSQL config file. But the feed aggregator’s config is just URLs, IDs, credentials, and other dynamic data, which do not change app logic, and are changed pretty often. With the current approach, we have to build a new image on every change in configuration, which complicates the delivery workflow.