no-dangling-commas about clearphp HOT 9 CLOSED

I am in agreement with @philsturgeon. While strictness is generally admirable, it's decidedly lame in this situation. Trailing commas don't degrade the readability of code whatsoever. A stricter policy only creates unnecessary obstacles and gotchas. I routinely thank PHP's syntax when I can effortlessly copy or re-order lines of key/val pairs without having to worry about that trailing comma. When I have to switch to coding in JS I curse it's strict nature.

from clearphp.

Changing all arrays to remove them is futile : I'd classify this as coding convention, rather than less bug-prone code.

Out of 200 PHP projects, a very small minority followed this.

I don't like that rule too much myself. :)

from clearphp.

So remove it! 👍

from clearphp.

I'm +1ing the "Remove it" - this is exactly the OPPOSITE of most coding standards and against the advice I give people when coding in PHP - it's far less error prone to always have a trailing comma after array entries - causes fewer merge conflicts and far fewer parse errors when you add/remove entries :)

from clearphp.

A clarification to the comment from @philsturgeon — the most compelling reason I've seen stated for keeping the trailing comma on multi-line array definitions is for simplifying diffs associated with version control. Essentially, adding or removing an array entry only changes that line, and no others; if you require that the last entry MUST NOT have a comma, then:

• removing the last entry ALWAYS results in a two-line diff, as the previous line must now change to remove the comma
• adding a new entry at the end ALWAYS results in a two-line diff, as the former last entry now must add a comma
• re-ordering that involves the last entry ALWAYS results in N+1 lines of diff (again, because whatever the new last entry is must also remove the comma)

Essentially, trailing commas simplify diffs and reduce merge conflicts. I only wish JavaScript allowed it! (I've become so accustomed to doing it in PHP that I've introduced errors in my JavaScript and JSON by keeping the trailing commas!)

from clearphp.

 (I've become so accustomed to doing it in PHP that I've introduced errors in my JavaScript and JSON by keeping the trailing commas!)

Real problem.

from clearphp.

Trailing commas for the win 👍

from clearphp.

+1 on trailing comma's, aka removing this rule.
It helps prevents parse errors from copy/paste actions, so should be considered a good thing‎™‎

from clearphp.

OK. Rule removed.

from clearphp.