Always Ha(ve|s) Visibility and Interfaces about clearphp HOT 6 CLOSED

Thanks for the has/have fix.

As for interfaces, I added a section 'When not to use it', for interface methods.
(imho), I'd keep the 'public' mention, as it is not always obvious if a method is from an interface or not : as such, I prefer to keep it simple, constant and consistent. But I understand your point.

from clearphp.

I specifically talked about interfaces, classes that implement methods from an interface of course have to specify the visibility. Java is a good example on how this should be done.

interface I {
    function f();
}

class C implements I {
    public function f() {}
}

from clearphp.

Just my two pennies: for auto-documenting code and consistency, I would always recommend making the visibility of methods in an interface explicit.

from clearphp.

manual-documenting

Corrected that for you, it is already auto-documented through the language specification, and the mere fact that a fatal error is emitted if you write anything other than public. 😉

from clearphp.

t is already auto-documented through the language specification

For experienced devs: true. For less experienced devs: not so much. I've even met PHP devs with 5+ years experience who've never come across the docs before, so you're presuming knowledge which may well not be there.

from clearphp.

@Fleshgrinder : I think I read too fast your initial suggestion. Always visibility for classes's methods. And also for traits.

I'll keep the 'public' recommended for 'interfaces', in the 'when not to use it' section. Personally, I'll probably use your convention.

from clearphp.