dsd-dbs / capellambse-context-diagrams Goto Github PK

Hi all,
I realised that on physical architecture level the components are not having the expected color:
Node: Yellow
Behaviour: Blue (like logical components)

This feature should give the option to place the icon at any place relative to the parent box. This will need functionality in capellambse.

Exchange items filter ask for .exchange_items unsafely. This raises an AttributeError during filter application which is unexcepted.

The title describes it all. This can be achieved easily by extending the filters. The task is to add a filter-function to the FILTER_LABEL_ADJUSTERS registry.

When starting completely fresh without npm and elkjs installed, one in the documentation and can't find anything regarding installation of elkjs. This should be included. With the current version it seems like there is no need to do anything beside the pip install capellambse-context-diagrams command.

It appears that filters are not applied for context diagrams of ComponentExchange objects.

Compare the first diagram (which should show the aptly named "ExchangeItem 1" on the functional exchange) with the following two diagrams for a LogicalFunction; the last of which has the FEX_OR_EX_ITEMS filter enabled as well and correctly shows the exchange item.

❯ ./capellambse/repl.py test-5.0

============================== Model exploration ===============================
`model` is '5_0' from tests/data/melodymodel/5_0/Melody Model Test.aird

>>> from capellambse_context_diagrams import filters
>>> obj = model.search("ComponentExchange").by_name("Teacher Responsibilities")
>>> obj.context_diagram.filters = [filters.FEX_OR_EX_ITEMS]
>>> obj.context_diagram
<Diagram 'Interface Context of Teacher Responsibilities'>

>>> obj = model.search("LogicalFunction").by_name("Teaching")
>>> obj.context_diagram
<Diagram 'Context of Teaching'>

>>> obj.context_diagram.filters = [filters.FEX_OR_EX_ITEMS]
>>> obj.context_diagram
<Diagram 'Context of Teaching'>

A user requested to add the interface to the diagram to close the gap to Capella.

For a PC [NODE], without any Physical Functions, but with deployed PC [BEHAVIOR], and Physical Links to other PC [NODE], there is no context shown, just a yellow box. Is this expected?

For this model:

The output of model.pa.all_components.by_name("PC 37").context_diagram looks as follows:

Have a look. Apply latest changes from the cookiecutter-template.

Add an option to filter out roots in the diagram.