drbawb / aqua Goto Github PK

Due to UAC's policy (WIndows > Security > Local Policies > User Rights Assignment > Create Symbolic Links) you need a command line w/ elevated privileges to create symbolic links. As such the utility must be run from an elevated command prompt to produce output.

For a production ready version I'd like to have it either prompt the user for elevation, and/or not require elevation at all.

POST /entries/upload HTTP/1.1
Host: localhost:3000
Connection: keep-alive
Content-Length: 136074
Origin: http://localhost:3000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36
Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryqgbABL6DETm5Ukbt
Accept: */*
Referer: http://localhost:3000/dash
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.8

------WebKitFormBoundaryqgbABL6DETm5Ukbt
Content-Disposition: form-data; name="upload"; filename="The Microsoft Sound.wav"
Content-Type: audio/wav


------WebKitFormBoundaryqgbABL6DETm5Ukbt--

Results in: ERROR:hyper::server: request error = Header

Just from a quick glance it seems like occasionally requests are being interleaved. I should probably switch to a real logging crate at some point.

These need to be cleaned up and replaced with proper error handling.

Afterwards the C FFI should have some mechanism to report errors, thoughts include:

• Caller passes an "out param" which we fill in with a status code
• Mutable thread local "last error code" and associated FFI retrieval function
• Return (status, char *) tuple, respecting alignment & padding

Known Parser Errors

• Incomplete groups

  • e.g: (()
    • The parser will reach EOF while there is still a suspended context on the stack.
      This would be considered an error condition. (e.g: unexpected EOF)
  • e.g: )
    • The parser would try to pop a suspended context that does not exist.
      This would be considered an error, but care must be taken to report it
      at the appropriate time. (Depending on how parens are nested it might
      not trigger until processing an unrelated grouping.)

• Incomplete expressions

  • e.g: + tag
  • e.g: tag +
  • When resolving a context the data stack would be exhausted too early.

• (Future) Incomplete escape sequence

  • e.g: foo\
  • If there is no token following the escape sequence it will be treated as an
    unexpected EOF.