dracos / django-date-extensions Goto Github PK

I am incrementally upgrading an old site to the latest version of Django, and right now with Django 2.1 and 2.2 installed, I am getting an error every time I test display of a page that uses ApproximateDateField:

WARNING:py.warnings:~/.virtualenvs/[my-env]/lib/python3.7/site-packages/django/db/models/sql/compiler.py:1072: RemovedInDjango30Warning: Remove the context parameter from ApproximateDateField.from_db_value(). Support for it will be removed in Django 3.0.
  RemovedInDjango30Warning,

It seems like though it's an argument in the method (default to None), the context isn't actually used in the method.

I'm about to upgrade the site to Django 3.0 next. Is this an issue that you might address, or is this user error on my end? Thanks.

When I try to serialize my development database into a fixture with the command:

$ python manage.py dumpdata --indent 4

I get the following traceback:

CommandError: Unable to serialize database: 'ApproximateDateField' object has no attribute '_get_val_from_obj'
Exception ignored in: <generator object cursor_iter at 0x7fd5723027b0>
Traceback (most recent call last):
  File "/home/jonancm/.cache/pypoetry/virtualenvs/gamehunter-gvZjkORE-py3.8/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1609, in cursor_iter
    cursor.close()
sqlite3.ProgrammingError: Cannot operate on a closed database.

I'm using the following software versions:

• django-date-extensions 3.1
• Django 3.1.4
• Python 3.8.5

Doing a quick research, I found a Django ticket that deprecates this method.

In the Django documentation on how to write custom model fields, I found that you should use the method value_from_object to implement the method value_to_string.

As of now, django-date-extensions implements ApproximateDateField.value_to_string relying on Field._get_val_from_obj:

In the aforementioned ticket, you can see the Field._get_val_from_obj method was deprecated because it duplicates the functionality of Field.value_from_object.

I haven't found any other uses of value_from_object in the codebase, so the solution should be fairly easy: just replace value_from_object with value_from_object in line 155 of fields.py.

I will try this and submit a pull request if I manage to solve the issue.

There does not seem to be a way to keep / specify the format you want the widget to output.
For example if I put "01/05" and save the object and then retrieve it again it displays as "5th January". I would like a way to say display as "01/05".

Hi guys,

I ran into a UnicodeEncodeError ('ascii' codec can't encode characters in position 0-5: ordinal not in range(128), The string that could not be encoded/decoded was: Январь 1996) when rendering a template using django-date-extensions ApproximateDateField together with djangos built-in i18n translation framework (languages English and Russian).

Turns out that a missing unicode method for the ApproximateDate class seems to be responsible as renaming the str method (line 47 in fields.py) to unicode fixed the problem.

Maybe you could consider adding it upstream.

Great thanks for the very useful extension package, you saved me a lot of time and trouble!

Cheers,
Felix

I understand the choice of CharField for ApproximateDateField but a PositiveIntegerField would be a better choice as that will allow sorting as well. E.g. can be used in order_by. What are your thoughts on this? (If you are agree I can create a pull request)

Trying to run on django 2.0 I got this error:
File "/home/mark/python-projects/django_date_extensions/example/urls.py", line 1, in
from django.conf.urls import patterns
ImportError: cannot import name 'patterns'

In urls.py, you have:

from django.conf.urls import patterns
from .views import view

urlpatterns = patterns(
    '',
    (r'^$', view),
)

In django 2.0 forward, I believe it should be

from django.urls import path
from .views import view

urlpatterns =[
    path('', view),
]

Given an object with an ApproximateDateField (ADF), query for other objects with the same ADF. If the ADF field is None, other equivalent objects will not match.

e1 = MyEntity.objects.filter(pk=1)
assert e1.adf == None
e2 = MyEntity.objects.filter(pk=2)
assert e2.adf == None
assert MyEntity.objects.filter(adf=e1.adf).count() == 0

I would expect the query to return at least e2. I have to add special logic to filter instead on adf being equal to "" if adf is None.

I realize that in SQL that NULL <> NULL, but I tried doing this with other fields that support None and it worked.

My workaround:

q = q.filter(dob=self.dob) if self.dob != None else q.filter(dob='')

After upgrading to Django 2.2, I noticed I needed to generate some migrations. Note I was using version 2 of this library until just now, but upgrading to 3 didn't seem to help.

My model uses the field as follows:

dob = ApproximateDateField(default="", blank=True)

The migration created is:

    operations = [
        migrations.AlterField(
            model_name='snake',
            name='dob',
            field=django_date_extensions.fields.ApproximateDateField(blank=True, default=''),
        ),
    ]

When trying to migrate, I get the following error:

Traceback (most recent call last):
  File "./manage.py", line 27, in <module>
    raise e
  File "./manage.py", line 16, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/core/management/base.py", line 323, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/core/management/commands/sqlmigrate.py", line 30, in execute
    return super().execute(*args, **options)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/core/management/base.py", line 364, in execute
    output = self.handle(*args, **options)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/core/management/commands/sqlmigrate.py", line 64, in handle
    sql_statements = executor.collect_sql(plan)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/migrations/executor.py", line 225, in collect_sql
    state = migration.apply(state, schema_editor, collect_sql=True)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/migrations/migration.py", line 124, in apply
    operation.database_forwards(self.app_label, schema_editor, old_state, project_state)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/migrations/operations/fields.py", line 249, in database_forwards
    schema_editor.alter_field(from_model, from_field, to_field)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/backends/base/schema.py", line 535, in alter_field
    old_db_params, new_db_params, strict)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/backends/postgresql/schema.py", line 124, in _alter_field
    new_db_params, strict,
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/backends/base/schema.py", line 648, in _alter_field
    old_default = self.effective_default(old_field)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/backends/base/schema.py", line 233, in effective_default
    return field.get_db_prep_save(self._effective_default(field), self.connection)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/models/fields/__init__.py", line 793, in get_db_prep_save
    return self.get_db_prep_value(value, connection=connection, prepared=False)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django/db/models/fields/__init__.py", line 788, in get_db_prep_value
    value = self.get_prep_value(value)
  File "/Users/john/.venv/mm/lib/python3.7/site-packages/django_date_extensions/fields.py", line 146, in get_prep_value
    if not ansi_date_re.search(value):
TypeError: cannot use a string pattern on a bytes-like object

Seems this might have to do with version support for django, and the use of the six package. For example: jazzband/django-auditlog#231

In my case:
python 3.6.9
django: 3.0.5

models.py:
from django_date_extensions.fields import ApproximateDateField

settings.py:
INSTALLED_APPS = [
...
'django_date_extensions'
....]

on makemigrations:
from django.utils.encoding import python_2_unicode_compatible
ImportError: cannot import name 'python_2_unicode_compatible'

Hi,

I've found django-date-extensions really useful with Django 1.10, but after switching to Django 1.11 I get the following error in fields.py:

File "...\lib\site-packages\django_date_extensions\fields.py", line 164, in init
super(ApproximateDateFormField, self).init(*args, **kwargs)
TypeError: init() got an unexpected keyword argument 'empty_value'

I use the ApproximateDateField in my model like this:

date = ApproximateDateField(null=True)

and set up the form in Django Admin like this, setting width and height for some form fields, but nothing special for theApproximateDateFormField:

def get_form(self, request, obj=None, **kwargs):
form = super(LetterAdmin, self).get_form(request, obj, **kwargs)
...
return form

I know that empty_value is a new attribute of CharField, added in Django 1.11, but I don't know what needs to be done about it. Are there plans to update django-date-extensions to support Django 1.11?

Thanks,
Claire