drachtio / drachtio-sip Goto Github PK

https://github.com/davehorton/drachtio-sip/blob/75f5dac8d128ceb6bf04bf288f816a51c23fbdd9/lib/parser.js#L395

By https://www.w3.org/Protocols/rfc1341/7_2_Multipart.html, the boundary starts with \r\n-- and following \r\n\ belongs to the segment:

        delimiter := CRLF "--" boundary   ; taken from  Content-Type 
        field. 
                                       ;   when   content-type    is 
        multipart 
                                     ; There must be no space 
                                     ; between "--" and boundary. 

App Crashed with the following error.

/home/asdf/node_modules/drachtio-sip/lib/message.js:14
Object.assign(this.headers, msg.headers || {});

TypeError: Cannot read property 'headers' of undefined
at new SipMessage (/home/asdf/node_modules/drachtio-sip/lib/message.js:14:39)
at DrachtioAgent._onMsg (/home/asdf/node_modules/drachtio-srf/lib/drachtio-agent.js:548:24)
at WireProtocol.emit (events.js:310:20)
at WireProtocol.EventEmitter.emit (domain.js:482:12)
at WireProtocol.processMessageBuffer (/home/asdf/node_modules/drachtio-srf/lib/wire-protocol.js:270:12)
at WireProtocol._onData (/home/asdf/node_modules/drachtio-srf/lib/wire-protocol.js:304:14)
at Socket.emit (events.js:310:20)
at Socket.EventEmitter.emit (domain.js:482:12)
at addChunk (_stream_readable.js:286:12)
at readableAddChunk (_stream_readable.js:264:11)

The app was running fine, and the next day it was crashed with the above error. There was no more trace other than this.

https://github.com/davehorton/drachtio-sip/blob/75f5dac8d128ceb6bf04bf288f816a51c23fbdd9/lib/parser.js#L400

Content-type of the segments sometimes miss space after the column
Content-Type:application/sdp\r\n
therefore the line 400
const ct = /Content-Type:\s+(.*)\r\n/.exec(segments[i]) ;
does not extract type. The fix is to allow 0 or more \s like
const ct = /Content-Type:\s*(.*)\r\n/.exec(segments[i]) ;

the regex in parseUri assumes host names will be in dot decimal format

These two functions require sip: prefix and don't work with TLS's sips: prefix.

  Object.defineProperty(this, 'calledNumber', {
    get: function() {
      const user = this.uri.match(/sip:(.*?)@/) ;
      if (user && user.length > 1) {
        return user[1].split(';')[0] ;
      }
      return '' ;
    }
  }) ;
  Object.defineProperty(this, 'callingNumber', {
    get: function() {
      const header = this.has('p-asserted-identity') ? this.get('p-asserted-identity') : this.get('from') ;
      const user  = header.match(/sip:(.*?)@/) ;
      if (user && user.length > 1) {
        return user[1].split(';')[0] ;
      }
      return '' ;
    }
  }) ;```