dpjudas / uicore Goto Github PK

I am trying to implement a custom view that has a keyboard accelerator. So when 'A' is pressed, this event is procesed even though the view does not have focus.

There appears to be 3 options:

1. I could hook directly into the display window slot to do this, however the view may be hidden or disabled (i.e. not part of the view tree).

2. Fire off the event on the root view in the ViewTree to cascade. However View::dispatch_event() dispatches messages at the target (and parent), not the child

3. Add a keyboard event slot on the ViewTree. The problem with this is when should the custom view connect the slot or disconnect the slot. i.e. If the View is unlinked from the ViewTree, the slot shouldn't be called. Then again, does all events have this same problem?

Any thoughts?

I have been experimenting in optimisation StyleCascade.

In my opinion, this is not required at the moment, unless like me, you have over 200 views which is unusual.

Simplified explanation:
I changed the StyleCascade property names to contain a hash value.
This has a nice side effect when obtaining properties that have index values: we can incorporate the index directly into the hash without requiring using the "integer to string" function overhead.

In my application, FPS increased from 138 to 192.

In addition, if I force the background renderer to use canvas.fill_rectangle() instead of using path draw when an exact rectangle is drawn, then FPS increases to 273

In https://github.com/dpjudas/UICore/blob/master/Sources/UICore/UI/View/view.cpp
In Function: void ViewImpl::render(View *self, const CanvasPtr &canvas)
At Line 1061:
contains:
Rect border_box = view->geometry().border_box();
Is this a typo, should we use Rectf instead of rect ?
Rectf border_box = view->geometry().border_box();