downthemall / downthemall-legacy Goto Github PK

View Code? Open in Web Editor NEW

518.0 518.0 149.0 12.09 MB

Official DownThemAll! repository. Pull requests welcome.

Home Page: https://downthemall.org/

License: Other

JavaScript 90.42% CSS 7.68% Python 1.62% HTML 0.29%

downthemall-legacy's Introduction

DownThemAll! WE

The DownThemAll! WebExtension.

For those still on supported browser: Non-WebExtension legacy code.

About

This is the WebExtension version of DownThemAll!, a complete re-development from scratch. Being a WebExtension it lacks a ton of features the original DownThemAll! had. Sorry, but there is no way around it since Mozilla decided to adopt WebExtensions as the only extension type and WebExtensions are extremely limited in what they can do.

For what is planned (and not planned because impossible to do in WebExtensions), see TODO.md.

What this furthermore means is that some bugs we fixed in the original DownThemAll! are back, as we cannot do our own downloads any longer but have to go through the browser download manager always, which is notoriously bad at handling certain "quirks" real web servers in the wild show. It doesn't even handle regular 404 errors.

I spent countless hours evaluating various workarounds to enable us to do our own downloads instead of relying on the downloads API (the browser built-in downloader). From using IndexedDB to store retrieved chunks via XHR, to doing nasty service-worker tricks to fake a download that the backend would retrieve with XHR. The last one looks promising but I have yet to get it to work in a manner that is reliable, performs well enough and doesn't eat all the system memory for breakfast. Maybe in the future...

What this also means is that we have to write our user interface in HTML, which never looks "native" and cannot offer deep OS integration.

But it is what it is...

What we can do and did do is bring the mass selection, organizing (renaming masks, etc) and queueing tools of DownThemAll! over to the WebExtension, so you can easily queue up hundreds or thousands files at once without the downloads going up in flames because the browser tried to download them all at once.

Translations

If you would like to help out translating DTA, please see our translation guide.

Development

Requirements

node
yarn
python3 >= 3.6 (to build zips)
web-ext (for development ease)

Setup

You will want to run yarn to install the development dependencies such as webpack first.

Making changes

Just use your favorite text editor to edit the files.

You will want to run yarn watch. This will run the webpack bundler in watch mode, transpiling the TypeScript to Javascript and updating bundles as you change the source.

Please note: You have to run yarn watch or yarn build (at least once) as it builds the actual script bundles.

Running in Firefox

I recommend you install the web-ext tools from mozilla. It is not listed as a dependency by design at it causes problems with dependency resolution in yarn right now if installed in the same location as the rest of the dependencies.

If you did, then running yarn webext (additionally to yarn watch) will run the WebExtension in a development profile. This will use the directory ../dtalite.p to keep a development profile. You might need to create this directory before you use this command. Furthermore yarn webext will watch for changes to the sources and automatically reload the extension.

Alternatively, you can also yarn build, which then builds an unsigned zip that you can then install permanently in a browser that does not enforce signing (i.e. Nightly or the Unbranded Firefox with the right about:config preferences).

Running in Chrome/Chromium/etc

You have to build the bundles first, of course.

Then put your Chrome into Developement Mode on the Extensions page, and Load Unpacked the directory of your downthemall clone.

Making release zips

To get a basic unofficial set of zips for Firefox and chrome, run yarn build.

If you want to generate release builds like the ones that are eventually released in the extension stores, use python3 util/build.py --mode=release.

The output is located in web-ext-artifacts.

-fx.zip are Firefox builds
-crx.zip are Chrome/Chromium builds
-opr.zip are Opera builds (essentially like the Chrome one, but without sounds)

The AMO Editors tl;dr guide

Install the requirements.
yarn && python3 util/build.py --mode=release
Have a look in web-ext-artifacts/dta-*-fx.zip

Patches

Before submitting patches, please make sure you run eslint (if this isn't done automatically in your text editor/IDE), and eslint does not report any open issues. Code contributions should favor typescript code over javascript code. External dependencies that would ship with the final product (including all npm/yarn packages) should be kept to a bare minimum and need justification.

Please submit your patches as Pull Requests, and rebase your commits onto the current master before submitting.

Code structure

The code base is comparatively large for a WebExtension, with over 11K sloc of typescript. It isn't as well organized as it should be in some places; hope you don't mind.

uikit/ - The base User Interface Kit, which currently consists of
- the VirtualTable implementation, aka that interactive HTML table with columns, columns resizing and hiding, etc you see in the Manager, Select and Preferences windows/tabs
- the ContextMenu and related classes that drive the HTML-based context menus
lib/ - The "backend stuff" and assorted library routines and classes.
windows/ - The "frontend stuff" so all the HTML and corresponding code to make that HTML into something interactive
style/ - CSS and images

downthemall-legacy's People

Contributors

Stargazers

Watchers

Forkers

forhart flimble ziahamza nmaier steven-collins-omega babarnazmi kunalbhushan dnaita justinhop culmat leonlee armangithub hrushikesh198 refack wenketel alephnaughty ajorpheus luislobo brianpow cha63501 mbemidio makhdumi ppoirier1 defconcepts nazar-pc seagat2011 owd-larrd cubedj jonathanxavier colt365 adammendoza dns todeale nisarpro mypersonalforks chtw31 hansii99 ivaylo5ev spivegin dinneo aquatanggo jn7163 nickkarras genpix ddraws toshiya44 katrinleinweber shijiema 4ria samuelwn americast smdvw5 pharaoh2234 fjahn78 jameslinus sangohan doneykoo lfyg foxhnd minhnhut0602 appotry y-aok tow3r91 lyx13710 bron84 rural64 rlaumeyer xerta555 stevenlol abdihaikal sockb4t tddmanju luizgsa21 vjandrea cbgilbert emtee40 drogers141 sheinmyintaung hejiang2000 jmcabandara kecmaster shkodskihk xbm3 andrelomba86 sausame cheerhawk francewhoa liberodark profounddarkness mdfb soybeanmeal ouiji geomorillo c0ns0le ssteinerx 0ljik redtestament tarekjor tony-aln repoarchiver

downthemall-legacy's Issues

Stuck on "loading .."

Your DownThemAll! and Browser Version and Operating System

Firefox 48
Ubuntu 16.04
DownThemAll 3.02

Expected Behavior

Right click link -> DownThemAll selection -> Start -> interface opens, downloads begin

Actual Behavior

Right click link -> DownThemAll selection -> Start -> interface opens, stuck on "loading ..."

Steps To Reproduce

Right click link -> DownThemAll selection -> Start

Additional info such as log extracts

Log empty

Checksum digest no being saved.

DownThemAll! 3.0.3 - Firefox 48.0.2 - Windows 10

Expected Behavior

Within firefox's interface, any download event that prompts a DownThemAll! "Add Downloads" window to show up, must do so in such a way that the checksum digest you have entered for the very first time, remains saved even after clicking the "Start!" button to initiate the download.

Actual Behavior

A checksum digest gets discarded, soon after firefox detects a download and a DownThemAll! "Add Downloads" window shows up, and you enter this checksum digest for the very first time, and click the "Start!" button to initiate the download.

Steps To Reproduce

If you use any means to save a file anywhere inside firefox, that would prompt DownThemAll! to show the main "Add Downloads" window, and at that first moment, you were to add a checksum digest and hit "Start!", the checksum digest just entered would be lost. As if you had not entered one at all.

Additional info such as log extracts

Even if after the downloaded is added / initiated and the "Download Information" window shows no checksum digest you still can add the checksum digest - again - and click "OK" and this time the checksum digest will be saved.

As a work around you can bypass this bug if you are able to start the same download manually!

When the file to be downloaded is added manually by clicking the "Manually add a download to DownThemAll" button and then the checksum digested is entered and the "Start!" button is clicked, the checksum digest is saved properly.

Regex filters goes strange on DTA 3.0.3

DownThemAll! 3.0.3
firefox 48.0.2 32bit
Windows 7 SP1 64bit

the page is https://konachan.com/post/show/226871
and my filter /^https?\:\/\/konachan\.com\/image\/.*(png|jpg|jpeg|gif|bmp|tiff)
it matches

http://konachan.com/jpeg/bcf578b09b1d0fdab4ac02d64d2d9230/Konachan.com%20-%20226871%20aqua_eyes%20armor%20blonde_hair%20bodysuit%20boots%20breasts%20collar%20elbow_gloves%20gloves%20hat%20long_hair%20navel%20skintight%20thighhighs%20uyu_%28keyakinoki%29.jpg
http://konachan.com/image/bcf578b09b1d0fdab4ac02d64d2d9230/Konachan.com%20-%20226871%20aqua_eyes%20armor%20blonde_hair%20bodysuit%20boots%20breasts%20collar%20elbow_gloves%20gloves%20hat%20long_hair%20navel%20skintight%20thighhighs%20uyu_%28keyakinoki%29.png

but in the previous version of DTA it only matches the second url ( my hope ).

But, if I change this filter to /^https?\:\/\/konachan\.com\/image\/.*(png|jpg|jpeg|gif|bmp|tiff)/i,
this time it only matches the second url, just like the previous version of DTA.

DownThemAll! Selection cuts links on $ symbol

Just try to select these links in plain text:

www.example.com/folder$file1
www.example.com/folder$file2

It parses them as www.example.com/folder

Search icon is squashed horizontally

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.2
Firefox 48.0 on Arch Linux x86_64.

WM = QTile

Screen res = 1680x1050

xdpyinfo | grep res reports "90x88 dots per inch"

Expected Behavior

Search icon looks roughly square overall, with a circular lense in the magnifying glass.

Actual Behavior

The search icon -- and ONLY the search icon -- is squashed horizontally in DTA Manager. All other icons in DTA and all other programs look correct ( meaning their overall dimensions are square).

Screenshot:

Comment

If this is an intentional attempt to save horizontal space, it would look a lot less odd IMO to just reduce both dimensions equally.

DownThemAll disappeared from menus

Your DownThemAll! and Browser Version and Operating System

Firefox 47.0.1

Expected Behavior

DownThemAll options visible in Tools menu (yes, these are checked in addon dialogue)

Actual Behavior

It's not there, nor is it in the right click menu popup.

Steps To Reproduce

Allow DownThemAll to update automatically and restart Firefox?

DTA asks if I want to remove files even if they no longer exist

Your DownThemAll! and Browser Version and Operating System

DTA v3.0.5, Firefox v48.0.2, Win7x64

Expected Behavior

Before the last update, it only asked if I want to remove... [fillowed by filenames], which was a convenient way for me to know if I moved those files from the main Download folder to where they belong (or if I missed ). If none of the selected files were there, no question was shown.

Actual Behavior

Now it shows the filenames even if they are not in Download folder any more.

Steps To Reproduce

Download a file/files. Move/Delete them. Right-Click on the file in DTA window and choose "Delete File(s)"

Additional info

May be a bit off topic, but this is a feature I wanted in DTA for a long, and it could help better organize the files you download. I really miss a "Move" button in DTA Right-Click menu. e.g. Select my files, Right-Click -> Move, then choose the folder I wish to move the selected files to.

EDIT:
Also the "Delete File(s)" button is grayed out if one of the selected files is skipped/404'd (the progress bar is red).

Download rename pattern not behaving the same as pre 3.x version

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5
Firefox 47.0
Fedora 22 - Linux XXXXXXX 4.4.14-200.fc22.x86_64 #1 SMP Fri Jun 24 21:19:33 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

Expected Behavior

Download with save pattern: *curl*/*name*.*ext*
Downloading http://host.com/path/file.jpg savse as host.com/path/file.jpg
This is what previous versions did

Actual Behavior

Download with save pattern: *curl*/*name*.*ext*
Downloading http://host.com/path/file.jpg saves as host.com/path/file.jpg/file.jpg

Steps To Reproduce

Download a file with above pattern pre 3.X and with latest.

Manager window disappeared ; Firefox session loading broken

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5
Firefox 48.0.2
Win7-32

Expected Behavior

Manager window should open...

Actual Behavior

It does not.

Steps To Reproduce

When choosing right-click and "save with DTA" or by going to the menu and selecting DTA Tools->Manager, nothing happens.

Additional info such as log extracts

This started last night when I tried to download a file and since then the manager window has gone AWOL. I tried disabling the extension, restarting Firefox and enabling it... this problem has also broken the Session Manager session loading on startup.

DTA-log.txt

Right-click downloads no longer work. How do I revert to previous version and disable updates?!

Your DownThemAll! and Browser Version and Operating System

DownThemAll 3.0.5, Firefox 45.3.0, Windows 7 SP1 Ent

Expected Behavior

When right-clicking a Nitroflare download button, I get the options for "Save Link with DownThem All" or "Save link with dTa! OneClick." With version 3.0.3, I would click either of these options and get the expected behavior (i.e., dTa! dialogue for downloading or the dTa! manager windows shows up and the download starts automatically to the last known location.

Actual Behavior

I get an error message saying "The selected link is not a file dTa knows how to download". This happens with a link that I was able to open & download this morning--the difference is with dTa, not Nitroflare. Furthermore, if I open up the manager and manually add the link, it works.

Steps To Reproduce

See above.

Additional info such as log extracts

Please enable Diagnostic Logging in the Privacy tab of the DownThemAll! preferences and either copy/paste essential part of the log or attach the entire log. Please note that the log may include sentitive information which you have to remove prior to posting it!
18:56:41::402
DownThemAll! (error) - Failed to get form data [Exception: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI]]
composeURL@chrome://dta-modules/content/loaders/integration-content.js?1472949682287:76:51
handleSaveTarget@chrome://dta-modules/content/loaders/integration-content.js?1472949682287:490:18

--> unknown:76:0
18:56:41::403
DownThemAll! (error) - Failed to process single link [Exception: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI]]
load/saveSingleLinkAsync/<() @ chrome://dta-modules/content/loaders/integration.js:481
TaskImpl_run() @ resource://gre/modules/Task.jsm:316
--> chrome://dta-modules/content/loaders/integration.js:481:0

"save form target" via right click doesn't work

Your DownThemAll! and Browser Version and Operating System

v3.0.5 ff 48.0.2 Windows 7

Expected Behavior

After right click and "save form target" (both options save with dta and save with dtaOneClick) the dta manager should open (if closed) and a download of the server response should start.

Actual Behavior

Neither the manager window opens nor the download starts.

Steps To Reproduce

Additional info such as log extracts

Where is the "power off computer after downloads complete"?

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.3
FF 48.0.2

Expected Behavior

Actual Behavior

Steps To Reproduce

Additional info such as log extracts

File access error when downloading fast

DownThemAll! and Browser Version and Operating System

Windows 10 (anniversary update), FireFox 48.0.2, DownThemAll 3.0.5

Expected Behavior

Download succeeds, even with high speed internet connection

Actual Behavior

When downloading at high speed (110 MB/sec optical fiber), most downloads fail pretty quickly and must be resumed, sometimes multiple times. It fails with message "File access error". There is sufficient space on disk. The more concurrent download, the more it seems likely to happen.

This did not happen with DownThemAll 2.x.

Steps To Reproduce

Download (big) file using a fast connection (the files I download are 4GB+)
Downloading multiple files in parallel seems to increase the probability of error.

Additional info : log extracts

DownThemAll! (debug) - shipping buffer: 16777216
    Chunk.prototype._shipBuffer() @ chrome://dta-modules/content/manager/chunk.js:319
    Chunk.prototype.write() @ chrome://dta-modules/content/manager/chunk.js:475
    Connection.prototype.onDataAvailable() @ chrome://dta-modules/content/manager/connection.js:454
--> chrome://dta-modules/content/manager/chunk.js:319:0
17:26:57::536
DownThemAll! (error) - Failed to write: 6762/16777216/16777216 [Exception: Component returned failure code: 0x80470007 (NS_BASE_STREAM_WOULD_BLOCK) [nsIOutputStream.writeFrom]]
    Buffer.prototype<.writeFrom() @ chrome://dta-modules/content/manager/chunk.js:104
    Chunk.prototype.write() @ chrome://dta-modules/content/manager/chunk.js:492
    Connection.prototype.onDataAvailable() @ chrome://dta-modules/content/manager/connection.js:454
--> chrome://dta-modules/content/manager/chunk.js:104:0
17:26:57::539
DownThemAll! (error) - write: E:\Download\rogxhfn281ay-{4c212655-4a71-42b9-8b96-d1b70aae4389}.dtapart [Exception: Component returned failure code: 0x80470007 (NS_BASE_STREAM_WOULD_BLOCK) [nsIOutputStream.writeFrom]]
    Buffer.prototype<.writeFrom() @ chrome://dta-modules/content/manager/chunk.js:104
    Chunk.prototype.write() @ chrome://dta-modules/content/manager/chunk.js:492
    Connection.prototype.onDataAvailable() @ chrome://dta-modules/content/manager/connection.js:454
--> chrome://dta-modules/content/manager/chunk.js:104:0
17:26:57::542
DownThemAll! (error) - onDataAvailable [Exception: Component returned failure code: 0x80470007 (NS_BASE_STREAM_WOULD_BLOCK) [nsIOutputStream.writeFrom]]
    Buffer.prototype<.writeFrom() @ chrome://dta-modules/content/manager/chunk.js:104
    Chunk.prototype.write() @ chrome://dta-modules/content/manager/chunk.js:492
    Connection.prototype.onDataAvailable() @ chrome://dta-modules/content/manager/connection.js:454
--> chrome://dta-modules/content/manager/chunk.js:104:0
17:26:57::545
DownThemAll! (debug) - write failed invoked! [Exception: Component returned failure code: 0x80470007 (NS_BASE_STREAM_WOULD_BLOCK) [nsIOutputStream.writeFrom]]
    Buffer.prototype<.writeFrom() @ chrome://dta-modules/content/manager/chunk.js:104
    Chunk.prototype.write() @ chrome://dta-modules/content/manager/chunk.js:492
    Connection.prototype.onDataAvailable() @ chrome://dta-modules/content/manager/connection.js:454
--> chrome://dta-modules/content/manager/chunk.js:104:0

Saves every file with "._mp4_" extension.

Your DownThemAll! and Browser Version and Operating System

DTA: 3.0.3; Browser: 48.0.2; OS: Windows 10

Expected Behavior

Save all file with it's original extension.

Actual Behavior

Starts download with "filename.mp4" format and saves with ".mp4" extension.
(there is underscore char after and before "mp4" as i mentioned title but github ignores them)

Steps To Reproduce

Additional info such as log extracts

Feature request: add multiple downloads from a link list

It would be great to have a possibility to add multiple downloads from the UI when having a link list. I mean something like a textarea where each row will be treated as a download link.

Currently I am resorting to editing any text element on a webpage, inserting links there, and feeding them to DTA!Selection, but that's very inconvenient.

select all under Filters not working

Your DownThemAll! and Browser Version and Operating System

v3.0.2 ff 47.0.1 Windows 7

Expected Behavior

under Filters > select all

Actual Behavior

It doesn't select links

Steps To Reproduce

Additional info such as log extracts

changed behavior of flatsubdirs_name.ext mask

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5 FF 49.0b8 Win 10 1607

Expected Behavior

Renaming mask: flatsubdirs_name.ext

no Character "-" at start of the filename
Example: "pub-ASUS-misc-utils_ASUS_XTU_V612208.zip"

Actual Behavior

Character "-" at start of the filename
Example: "-pub-ASUS-misc-utils_ASUS_XTU_V612208.zip"

Steps To Reproduce

Download - URL : http://dlcdnet.asus.com/pub/ASUS/misc/utils/ASUS_XTU_V612208.zip
Resulting download-filename in DTA 3.05: "-pub-ASUS-misc-utils_ASUS_XTU_V612208.zip"

Additional info such as log extracts

In all DTA Version til may 2016 (incl. nightly's) no leading "-" char.

Paused downloads don't remember segments after resuming

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5
FF 48.0
macOS 10.11.6

Expected Behavior

The paused downloading file resumed with segments column showing 10/10.

Example

Before Pausing
The downloading file segments column show 10/10.

After Resuming
The downloading file segments column show 1/10.

Actual Behavior

The paused downloading file resumed with segments column showing 1/10.

Example

Before Pausing
The downloading file segments column show 10/10.

After Resuming
The downloading file segments column show 10/10.

Steps To Reproduce

Download a large file (around 1 GB >; recommend download video file)
Switch to DTA window (Make sure Segments column is enabled)
Wait for it load until 300/400 MB
Pause it & Resume it (Why - Sometimes download speed drops which is why pausing/resuming the downloading file will "reset" the speed to become faster)

Notes

This issue does not affect DTA 2.0.19 and below

feedly podcast downloads broken

Video DownloadHeloper Support

Your DownThemAll! and Browser Version and Operating System

DownThemAll! 3.0.5
Firefox 48.0.2
Win 10

Expected Behavior

Downthemall should support Video DownloadHelper Extension

Actual Behavior

When I download video by Video DownloadHelper there is no way to download it with dta

Steps To Reproduce

Additional info such as log extracts

Titlebar drag broken in Win7 [was: No title bar on the manager window]

Your DownThemAll! and Browser Version and Operating System

DownThemAll! 3.0.3
Nightly 48.0
Windows 7 64 bit

Expected Behavior

Holding the left mouse button and moving the mouse on the title bar should move the manager, and right clicking should bring up the context menu with restore, move, size etc.

Actual Behavior

There is no title bar.

Steps To Reproduce

Open the manager and attempt to interact with the title bar.

Additional info such as log extracts

Using alt+space will still bring up the context menu, but it is rather annoying to press alt+space, m, arrow key, and then move the mouse to move the manager window.

Bandwidth limitation UI not user friendly for high bandwidth

Your DownThemAll! and Browser Version and Operating System

Windows 10, Firefox 48.0.2, DownThemAll 3.0.5
(This problem was also present in previous versions of DownThemAll).

Actual Behavior

When you have a high available bandwidth (1GBps), the bandwidth limitation feature (the bottom-right drop-down) is not user friendly : For example if I want to limit to 80 MB/s (80 000 KBps), I need to select 80 times the drop down and increase by 1Mpbs each time (which is the maximum step that the dynamic drop down provides).

Expected Behavior

Either the combo-box should be usable using keyboard, or the maximum step for values should dramatically increase when reaching higher values. Steps of 100KBps when reaching high values makes no sense.

Steps To Reproduce

Just try to limit bandwidth to 90MBps without losing patience.

DTA is no longer working with the blue 'Premium Download' button in uploaded.net

Your DownThemAll! and Browser Version and Operating System

DTA 3.05; Firefox 48.0.1; Mac OSX 10.11.6

Expected Behavior

On website uploaded.net, with previous version of DTA (2.0.19) I was able to right-click on 'Premium Download' button and select option 'Start saving Form Target with dTA OneClick!'. This would add the target file of the button to the DTA window.

Actual Behavior

Right-clicking on the 'Premium Download' button generates a popup stating that there were no files available that DTA could download - I forget the exact wording as I've reverted to DTA 2.0.19. Let me know if you'd like me to upgrade & reproduce, or want screenshots.

Steps To Reproduce

As above

Additional info such as log extracts

DTA manager window, right click menu "open directory" opens file instead for some extensions

Your DownThemAll! and Browser Version and Operating System

DTA 3.05, Fireforx 48.0.2 (32bit), Win 7 Pro SP1 (64bit)

Expected Behavior

DTA manager window, right click menu "open directory" opens directory [folder] where file has been downloaded.

Actual Behavior

For certain file extensions, file is opened instead (does not go to directory [folder]): .7z, .jpeg, .gif, .exe, .msi, .pdf (note "open file" is grayed out in these cases too). However, .jpg, .htm, .html, .zip, these extensions "open directory" works correctly (and "open file" in most cases is available). Have not tried other extensions as I currently don't have any downloads of them in the DTA manager window (like .txt, .doc, .docx, etc. -- I do have one .xls file, but both "open directory" and "open file" are grayed out despite the fact the file does exist at the downloaded location with the same exact name -- "rename" and "delete" are available though). Note, this is especially dangerous with executables being launched immediately -- I normally after downloading such files use the right-click "open directory" to go directly there to scan file with Malwarebytes and McAfee.

Steps To Reproduce

Tried several files of each type that I had available, it seems consistent, and every time I open the manager window (however, I didn't do more than 2 .exe files, because I don't want to launch multiple installations, and I have only one .msi).

Additional info such as log extracts

Set file time to last modified time (server) or time of queueing - not working

Your DownThemAll! and Browser Version and Operating System

Firefox 47.0.1
Windows 7
DownThemAll! 3.0.5

Expected Behavior

File time set to last modified time (server) or time of queuing

Actual Behavior

File time not being updated

Steps To Reproduce

Preferences.Advanced download control:
Put Check in box for Set file time to last modified time (server) or time of queuing
Download a file from an earlier date; saved file should have date and time of download

Additional info such as log extracts

Linux - DTA 3.0.5 - Need To Click Downloads Twice

Slackware 14.2 x86_64
Firefox ESR 45.3.0
Downthemall 3.0.5

When I click a download link, the Firefox save window appears as default, in order to get downthemall to appear in the save window, I now have to click a download link 2 times.

This did not happen in the previous version of downthemall.

I've also been using downthemall for as long as the project has been around in Linux and I've never had this happen until 3.0.5

All the downthemall settings are on default, I have not made any changes to it...

unhelpful ramblings

more unhelpful ramblings

Missing Icons

DownThemAll! 3.0.3 - Firefox 48.0.2 - Windows 10

Expected Behavior

In the main DownThemAll! window, the file icon's should not flicker on or of after you change the file's extension. Hovering the mouse cursor over the file name, should not flicker the file's icon on or of after changing it's extension via the main DownThemAll! window interface.

Actual Behavior

In the main DownThemAll! window - the one that shows the urls to download - if you change a file's extension, the preview of the file icon to the left of the file name only shows up when you hover over the file name with the mouse cursor.

Steps To Reproduce

As the file is downloaded, press F2 on the keyboard - or right click it and choose Rename - and change the file's extension.

Since DownThemAll! does not care to reflect the file name changes that happen outside it's interface - for instance, via windows explorer - renaming the file's extension outside of DownThemAll! does not trigger the icon flickering on mouse cursor hovering.

Additional info such as log extracts

No additional info.

curl has a changed behaviour (in field mask, "Maske" in german version)

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5, Firefox 48.0.2

Expected Behavior

Up to previous version the string curl*name_._ext* caused all images belonging to a certain folder on the server to be downloaded into one single local folder named exactly the same way as the folder on the remote server. This means curl did NOT include the filename and extension but just the server URL including the subdirs.

Actual Behavior

curl now seems to include also the filename and extension of each file. This means DTA creates a distinct folder for each downloaded image file by appending filename and extension first to the local folder name and then downloading the image itself into this folder. The old behaviour is more reasonable and useful than the new is since it downloads all files stored under a certain URL/folder on the remote server to one single folder on the local system.

Steps To Reproduce

Just try it... on my system this behaviour is exactly the same each time I try it out...

Additional info such as log extracts

Filters don't work

Your DownThemAll! and Browser Version and Operating System

dTa: 3.0.6
Firefox: 48.0.2
OS: Windows7

Expected Behavior

When I select a filter setup to get one string OR another, I expect to select all the items that contain those character strings.

Actual Behavior

When I enter any filter string that contains a dot ( . ), the filter doesn't recognize the string.

Steps To Reproduce

Try to create a filter that says "find all files that contain "//xa." OR "//ci."
Old filter format was "//xa.|//ci." This doesn't work anymore!!!

OR try to create a string that contains "//xa.yimg.com"

Additional info such as log extracts

Renaming of files with same name is broken

DTA 3.0.5, Firefox 48.0.2, Windows 7

Expected Behavior

When downloading multiple files that have the same name and the option to rename the new file is used, it obviously should rename them and end up all files downloaded with unique names.

Actual Behavior

This functionality is broken in the new version. If for example I were to download 15 files all named image.jpg, It will rename them, but it will rename multiple files to the same name and overwrite the existing ones. So, instead of ending up 15 files, you end up with maybe 5.
Attached screenshot of download manager to clarify

Steps To Reproduce

This occurs when concurrent downloads is set >1. The temporary workaround is to set concurrent downloads to 1 and it will rename all files uniquely.
In the old version it would work correctly even with concurrent downloads >1.

FlashGot Media not working with DownThemAll 3.0.3

Your DownThemAll! and Browser Version and Operating System

DownThemAll 3.0.3
Firefox 48.0.2 (32bit)
FlashGot 1.5.6.13
Windows 7 Pro 64bit

Expected Behavior

FlashGot Media opens DTA with list of media links

Actual Behavior

DTA does not open

Steps To Reproduce

Happens every time
Revert to DownThemAll! 2.0.19 and function is as expected.

Additional info such as log extracts

DTA 3.0.x conflict with userChromeJS 2.0 ? can't MANUALLY add download link, when userChromeJS 2.0 installed

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5
firefox 48.0.2 x86
windows 10 x64

Expected Behavior

DTA add download link normally

Actual Behavior

DTA can't MANUALLY add download link, when userChromeJS 2.0 installed.
snapshot:
http://i.imgur.com/5DZ1MLG.png
http://i.imgur.com/HB0WD1U.png
http://i.imgur.com/y2tSw54.png
http://i.imgur.com/SdsJdMR.png

Steps To Reproduce

create a clean profile, install both DTA 3.0.5 and userChromeJS 2.0, restart firefox.
menubar - tools - Downloadall Tools - Manager , type any url MANUALLY, there will be a red frame indicates an error.

Additional info such as log extracts

userChromeJS 2.0 url :
http://userchromejs.mozdev.org/

Downthemall! selection unable to detect links

Your DownThemAll! and Browser Version and Operating System

Firefox 48 Ubuntu 16.04

Expected Behavior

Be able to select Non hyperlinked text for download selection

Actual Behavior

Gives error notification saying "No Links or Pictures Found"

Steps To Reproduce

Example webpage from pastebin with links to Ubuntu ISOs
http://pastebin.com/YR1J7MZf

Highlight non hyperlinked text
right click and select "Downthemall! Selection"
Error notification pops up saying "No Links or Pictures found!"

Additional info such as log extracts

Drop last path element from flatsubdirs if "file" [was: Renaming Mask not respecting subdirectories]

Your DownThemAll! and Browser Version and Operating System

Firefox 48.02 64 bit on Windows 10 64 bit

Expected Behavior

Files saved to their common directory as a group
[Renaming Mask: flatcurl__flatsubdirsname_._ext]
e.g. url http://www.ibm.com/files/ should save as:
DTA\www.ibm.com-files\01.zip
DTA\www.ibm.com-files\02.zip
DTA\www.ibm.com-files\03.zip
(i.e. 3 files in 1 dir)

Actual Behavior

Individual files saved to unique directories named for the file (with the file name as part of the directory name)
e.g.
DTA\www.ibm.com-files-01.zipfiles\01.zip
DTA\www.ibm.com-files-02.zipfiles\02.zip
DTA\www.ibm.com-files-03.zipfiles\03.zip
(i.e. 1 file in each of 3 dirs)

Steps To Reproduce

Newest version of DTA (updated today) using 'DTA One-click'. This is the same renaming mask I have used successfully for years.

Additional info such as log extracts

E10 Multiprocess, Closed Private Windows Produce, "File Access Error".

Your DownThemAll! and Browser Version and Operating System

DownThemAll v3.0.5
Firefox v48.0.2 (Multiprocess Windows - 2/2 (Enabled by user))
Windows 10.1607

** Note, multiprocess has been manually activated in Firefox. **

Expected Behavior

Files download and finish without ending with error message, "file access error".

Downloaded files can be located in the download folder.

Actual Behavior

With multiprocess (E10's) activated and whilst using private windows, files download and finish with error message, "file access error", in DownThemAll. Note, private windows must all be closed whilst downloads are still in progress for the error message to appear before the downloads reach 100%. See steps to reproduce below. DownThemAll works fine otherwise.

Files cannot be located in either the temporary or download folders. I am assuming they get deleted in some way.

Steps To Reproduce

With E10's activated (Multiprocess Windows - 2/2 (Enabled by user)
Open a private window.
Go to a website and start downloading files.
Close private windows ** this must be done whilst downloads are still being downloaded! **
DownThemAll continues to download the files until 100% finished.
DownThemAll displays, "file access error".
Files cannot be found in either the temp or download folders.

Files can be resumed which restarts downloading the files from the beginning again. Files will complete 100% successfully without any problems.

Additional info such as log extracts

Feature request: config-table for Directory + Mask + Fast Filtering

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5 FF 49.0b8 Win10 1607

Expected Behavior

While adding a link (in the selection mask and in the save to mask) it should be possible to select a config-name, where the download directory, the filter mask and the fast filtering string is stored

Actual Behavior

Directory, filter mask and fast filtering have to select separate (with the possibility to make an mistake)

Steps To Reproduce

Additional info such as log extracts

Add tooltip to network status/offline icon

Regression on DTA language

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5, FF48 ,W10

Expected Behavior

French Language as locale are Fr-fr and DTA 2.8 was in French

Actual Behavior

English Language ( not desired as users are french only spoken).

Will go back to DTA 2.8 waiting for bugg fix.

Additional info such as log extracts

Manager window not auto-closing

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.1
FF 48.0.2 (edited for correct version number)

Expected Behavior

When finished getting image links from a page it used to auto-close the manager window.
It also should remove completed downloads. Both these options are ticked in the prefs.

Actual Behavior

After downloading the manager remains there, albeit minimised, and the file list is full of the completed files.

Steps To Reproduce

Not sure if it only works on an upgrade. But just download some stuff.

Additional info such as log extracts

Feature request: Dropdown Menus: increase number of entries to Keep from 15 to 50

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5 FF 49.0b9 Win10

Expected Behavior

Dropdown Menus: maximum number of entries to Keep is 15. Especially for the directory this is too low.

Actual Behavior

The maximum number of entries to Keep should be at least 50.

Steps To Reproduce

Additional info such as log extracts

select all ubder not working

Your DownThemAll! and Browser Version and Operating System

v3.0.2 ff 47.0.1 Windows 7

Expected Behavior

under Filters > select all

Actual Behavior

It doesn't select links

Steps To Reproduce

Additional info such as log extracts

First download not caught by DTA

Your DownThemAll! and Browser Version and Operating System

DTA 3.0.5, Firefox 48.0.2 and Windows 10 Pro

Expected Behavior

All downloads go to DTA

Actual Behavior

All but the first download of a browser session go to DTA

Steps To Reproduce

Restart Firefox and click a link that downloads a file.

Additional info such as log extracts

Icons for "Top" and "Bottom" buttons are off-center

Your DownThemAll! and Browser Version and Operating System

DownThemAll: 3.0.5
Firefox: 49.0a2 (2016-08-01)
OS: Lubuntu Linux 14.04

Expected Behavior

The "Top" and "Bottom" buttons should have their perceptual "center of mass" centered on the circles behind them.

Actual Behavior

The "Top" and "Bottom" buttons have the base of the triangles aligned with the bases of the triangles in the "Up" and "Down" buttons, which causes the added bars to make them appear unbalanced.

Additional info such as log extracts

New version of DTA downloads files that already exist even when "Skip" option is selected.

DTA version 3.0.2 (updated 2 Sept. 2016), Firefox version 47.0.1, Windows 7 Home Premium

I have configured DTA to skip a file in the download list if it already exists. Previous versions would check to see if a file existed BEFORE downloading it.

The current version downloads a file even if it already exists, then deletes it (the file it just downloaded). This wastes both time and bandwidth (especially for people with slow internet connections.

Select a file from a website for downloading and download it. Since your internet connection is probably much faster than mine, you will need to select a large file.
Repeat step 1 with the same file. Note that DTA now downloads the entire file before marking it as "skipped."

See the attached screenshot, part of an Explorer window. It shows that I downloaded a file on September 1. It is now September 2, and DTA is downloading the same file.

Skip 'when a file of same name exists' isn't working properly after the update

Your DownThemAll! and Browser Version and Operating System

downloadthemall 3 & firefox 48.0.2 & windows 10

Expected Behavior

I've chosen 'when a file with the same name already exists: skip,'
but after the update it no longer skips downloading, but instead
downloads the file to 99% and then designates the file as 'skipped'
when the download finishes

Actual Behavior

Before the update, it would check before the download began
rather than when the download was complete. If a file with the same
name existed -or- if another file with the same name was being
downloaded at the same time, then the file would be 'skipped' and
would never begin downloading. If the file downloads and then
skips at completion, then that wastes bandwidth.

Steps To Reproduce

Download a file, and then after it finishes, try downloading it
a second time. It should skip before the second download begins
but it doesn't skip until the second download is done. It should
prevent the second download if you choose 'skip' in the preferences.
Select a file to download, but choose 'add paused.' Then select
the same file for download again, also paused. Go to the manager
and start downloading both. With the 'skip' option chosen, it
should allow one to download but prevent the second identical
download from beginning. It doesn't. Both downloads occur at the
same time and the one which finishes second gets 'skipped' when
the download finishes.

Additional info such as log extracts

Temp File not Deleted

Your DownThemAll! and Browser Version and Operating System

Firefox 48.0.2
DTA 3.0.5
Win7-32

Expected Behavior

Temp file should be deleted when download is aborted.

Actual Behavior

Temp file remains.

Steps To Reproduce

In the middle of downloading, right click on the job and select "Remove Downloads". The job will be aborted but the temp file remains in the download directory. (if a new download is started for the same file, a new temp file is created)
This problem didn't exist before the upgrade to DTA 3.

Additional info such as log extracts

Feature Request: Filter based on detected type to exclude "share" links

Your DownThemAll! and Browser Version and Operating System

DownThemAll: 3.0.5
Firefox: 49.0a2 (2016-08-01)
OS: Lubuntu Linux 14.04

Expected Behavior

DownThemAll should have a way to filter based on whatever source it uses to assign icons to detected links. (This successfully identifies images without catching Pinterest share links)

Actual Behavior

DownThemAll seems to only allow filtering by raw URL matching, which results in false positives for Pinterest share links when you filter for images.

Steps To Reproduce

Go to any Tumblr blog which incorporates Pinterest buttons
Open DownThemAll's file picker to the links tab
Look at how actual images in the list get image icons while Pinterest links do not
Try toggling the images filter and look at how both images and Pinterest links get selected/deselected.

Additional info such as log extracts

Because I generally notice this on NSFW blogs, I'd rather not give a log.

Feature request: Hide/Show side toolbar

Your DownThemAll! and Browser Version and Operating System

DownThemAll: 3.0.5
Firefox: 49.0a2 (2016-08-01)
OS: Lubuntu Linux 14.04

Expected Behavior

An option to hide the left-side toolbar (and rely, instead, on the context menu for access to that functionality) should be present, either in its context menu (currently nonexistent) or in the preferences window.

Actual Behavior

I can't find such an option anywhere in DTA

Additional info such as log extracts

I don't see how diagnostic logging would be relevant to this specific issue. (Unless it would reveal that there's supposed to be a context menu but it's erroring out, but you'd know that without a log)

As soon as I can justify restarting my browser (I just had a crash yesterday, so maybe in another week) to enable InspectorWidget and DOM Inspector, I'll whip up a XUL Userstyle to hide the sidebar in the interim. (And, while I'm at it, the Donate! button. That green one is too ugly compared to the one that was integrated into the logo.)

Checksum Success failing to show up.

DownThemAll! 3.0.3 - Firefox 48.0.2 - Windows 10

Expected Behavior

After downloading a file with a checksum digest attached a icon or any indication of the success of checking the checksum digest could be shown on the interface. As was shown on previous versions.

Actual Behavior

After downloading a file with a checksum digest attached no icon or information is shown on the interface when the check succeeds. A message shows up when the file and the checksum digest mismatches - producing a failure - so the check is happening, but what happens if/when it succeeds ? Nothing shows up anywhere.

Steps To Reproduce

Right click a file that is still downloading or paused, add a checksum digest, hit ok. Un-pause it or let it finish. If The checksum digest matches the file nothing shows up, on a mismatch a message / dialog window appears.

Additional info such as log extracts

No additional info.