Standardize on a style for structs with no logic about corert HOT 5 CLOSED

If it doesn't hurt size/perf (which it shouldn't with inlining), C# conventions are to never expose public fields. What do you think of get-only properties (and sometimes primary constructors) from C# 6.0? The syntax looks like:

struct LocalDefinition (TypeDesc type, bool isPinned) // constructor parameters go next to the struct delcaration
{
    public int SomeReadOnlyInt { get; } = Math.Max(3, 4); // Can do some logic here
    public TypeDesc Type { get; } = type; // Can read constructor parameters here
    public bool IsPinned { get; } = isPinned;
}

from corert.

That C# 6 syntax is disgusting.

Although I do admit that in this case it has a nice side effect of making something that becomes de facto read only.

Not sure if we build with Roslyn on OSX and Linux though.

from corert.

FYI, the primary constructors feature was cut from C# 6

from corert.

C# conventions are to never expose public fields

This convention is for public types in frameworks. It was invented so that the type implementation can change without breaking the framework public surface.

The type system is not designed to be public framework. It is our internal implementation detail. We do not need to follow the guidelines for public frameworks in the implementation. We should prefer concise tight code instead - that the guidelines for public frameworks are often in conflict with.

from corert.

I'd also prefer public read-only fields.

from corert.