As a game developer I like to have some control over the thread priorities. <p di

Thread priorities on Unix about corert HOT 3 OPEN

RalfKornmannEnvision commented on September 22, 2024

Thread priorities on Unix

from corert.

Comments (3)

Suchiman commented on September 22, 2024

I remember stumbling upon this while hacking on the GC, specifically

corert/src/Native/gc/unix/gcenv.unix.cpp

Lines 1028 to 1038 in a7ff563

 // Boosts the calling thread's thread priority to a level higher than the default 

 // for new threads. 

 // Parameters: 

 // None. 

 // Return: 

 // true if the priority boost was successful, false otherwise. 

 bool GCToOSInterface::BoostThreadPriority() 

 { 

 // [LOCALGC TODO] Thread priority for unix 

 return false; 

 }

(which should be fixed as well) but i don't remember the exact reason. I thought i've read the priority cannot be changed after thread creation but that appears to be false.

from corert.

RalfKornmannEnvision commented on September 22, 2024

I remember seeing this when porting to the Switch/PlayStation

The place I was refering to is here:

corert/src/System.Private.CoreLib/src/System/Threading/Thread.CoreRT.Unix.cs

Lines 32 to 40 in a7ff563

 private ThreadPriority GetPriorityLive() 

 { 

 return ThreadPriority.Normal; 

 } 

 private bool SetPriorityLive(ThreadPriority priority) 

 { 

 return true; 

 }

Edit: Did a quick check. BoostThreadPriority is currently only used by the server GC for the GC threads. But it should be possible to implment it for Unix. But as I currently don't run a server GC I cannot test it

Edit2: Did some more digging. It seems that in many cases the OS is configured in a way that a regular process cannot change the thread priority. Therefore properly nobody cared that much. A quick check in the mono and runtime source showed that both have the code to support it when the OS allows it. Therefore I think we should have it in the same way in CoreRT.

PS: while trying around a little bit i fixed this TODO
// TODO: Figure out which scheduler to use, the default one doesn't seem to
// support per thread priorities.

It still has the limitation that it will only work when the OS allows it but if not it will just do nothing which is the same as now. I can make a PR for it

from corert.

jkotas commented on September 22, 2024

. It seems that in many cases the OS is configured in a way that a regular process cannot change the thread priority. Therefore properly nobody cared that much

Yes, that's correct.

It still has the limitation that it will only work when the OS allows it but if not it will just do nothing which is the same as now. I can make a PR for it

💯

from corert.

Recommend Projects

Thread priorities on Unix about corert HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// Boosts the calling thread's thread priority to a level higher than the default
	// for new threads.
	// Parameters:
	// None.
	// Return:
	// true if the priority boost was successful, false otherwise.
	bool GCToOSInterface::BoostThreadPriority()
	{
	// [LOCALGC TODO] Thread priority for unix
	return false;
	}

	private ThreadPriority GetPriorityLive()
	{
	return ThreadPriority.Normal;
	}

	private bool SetPriorityLive(ThreadPriority priority)
	{
	return true;
	}