Git Product home page Git Product logo

Comments (8)

eerhardt avatar eerhardt commented on May 23, 2024 1

We could add something to eng/common/

The other drawback to that approach is that repos don't get to decide where in the folder hierarchy the file needs to live. So in order for the script to be found, the calling scripts need to know where the $RepoRoot is - so they can find $RepoRoot/eng/common. There also may be files (like CMake files) that depend on being in a specific location in the folder structure.

IMO - the system should be built in such a way that files can be placed anywhere in the repo, and still be kept in sync with the 'master' script.

from arcade.

dagood avatar dagood commented on May 23, 2024

We need to make sure this change to symbol stripping gets in here: https://github.com/dotnet/core-setup/issues/1607. (Keeping unstripped binaries around even if symbol stripping is enabled, for certain scenarios where later tooling expects to do the stripping itself.)

from arcade.

jcagme avatar jcagme commented on May 23, 2024

A bit related to #53. We could add something to eng/common/. Drawback of this approach is that repos that don't need these files will end up with them in their repos anyway, probably not a big deal if the benefit is big

from arcade.

dagood avatar dagood commented on May 23, 2024

Maybe consider if this fits in with #774, dependency expression extensibility. That is, make the scripts a dependency repos can add if they need them, and express anywhere they want.

from arcade.

weshaggard avatar weshaggard commented on May 23, 2024

Yes I agree this should be extensible and repo's should be able to opt-in to particular folders and their locations. I was chatting with @mmitche about something similar for version updates but I think the same should hold true for file updates. Repo's can easily configure this in their Version.details.xml file.

from arcade.

mmitche avatar mmitche commented on May 23, 2024

Yeah that's what I'm thinking. I think we need more generic dependency expression, let me see what I can come up with.

from arcade.

riarenas avatar riarenas commented on May 23, 2024

@mmitche what do you want to do with this one?

from arcade.

mmitche avatar mmitche commented on May 23, 2024

I think we can close it. Most of the native code has been consolidated into runtime, so there is much less copying around now.

from arcade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.