Git Product home page Git Product logo

Comments (14)

andriipatsula avatar andriipatsula commented on September 22, 2024 1

Thanks @riarenas , I'll try to utilize the pipeline you posted. I have already published a package to our feed, but I think we can regenerate it.

from arcade.

riarenas avatar riarenas commented on September 22, 2024 1

Oh, if we have a working package that's good too! I was hoping to save you some manual operations but it looks like you're already too far along for that.

from arcade.

andriipatsula avatar andriipatsula commented on September 22, 2024 1

Oh, if we have a working package that's good too

I am testing it right now. Hope it's "working" :) But it's great that we have a pipeline that does the job.

from arcade.

chcosta avatar chcosta commented on September 22, 2024 1

@tkapin , You're right, I thought I had closed the loop here, but I didn't. There IS a pipeline I created to handle the package generation, but at the same time I was doing that, I was having conversations with 1ES about producing a package for us. 1ES is now producing a package for us. Hooray! So the "work" involved going forward would (theoretically) be, take the package from their feed, publish it to our feed, and update the version number. I'll prepare a PR to switch this over. If the new package doesn't break the world, I'll update the documentation.

from arcade.

riarenas avatar riarenas commented on September 22, 2024

@andriipatsula there's now a pipeline and script to generate this package as of #14130. The pipeline is at: https://dnceng.visualstudio.com/internal/_build/results?buildId=2295858&view=results

It doesn't look like the linked instructions have been updated to account for that, but I would not follow those manual steps for this.

I would try to use the pipeline to create the package. If you have any issues sync up with @chcosta

from arcade.

chcosta avatar chcosta commented on September 22, 2024

We should try the 1es package. I'll provide instructions later today

from arcade.

chcosta avatar chcosta commented on September 22, 2024

I wouldn't block on me though

from arcade.

tkapin avatar tkapin commented on September 22, 2024

@riarenas, @chcosta - After checking with @andriipatsula, none of us was aware of the pipeline's existence. I wonder if this was communicated to our team? The wiki instructions at RoslynTools.MSBuild-(xcopy-msbuild)-generation don't mention the pipeline existence as well.

The instructions should be updated, but it'd be good to have it done by someone who understand the process. Does this tooling have an owner or someone who's familiar with the topic? If so, could they update the wiki? Thanks

from arcade.

andriipatsula avatar andriipatsula commented on September 22, 2024

The package is created and tested here. I am going to create a PR in the dotnet/arcade repo.

from arcade.

andriipatsula avatar andriipatsula commented on September 22, 2024

PR to update the msbuild-xcopy in arcade: #14442

from arcade.

andriipatsula avatar andriipatsula commented on September 22, 2024

closing as resolved.

from arcade.

tkapin avatar tkapin commented on September 22, 2024

Thanks, that's fine, just please make sure this gets tracked so it's clear what the right action is. Do you prefer to have this issue reopened for that follow-up work or there is a dedicated issue for that already? Cheers!

from arcade.

chcosta avatar chcosta commented on September 22, 2024

Merged the change to use the 1es package - #14448

Instructions have been updated - https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng%20Services%20Wiki/1074/Updating-Microsoft.DotNet.Arcade.MSBuild.Xcopy-WAS-RoslynTools.MSBuild-(xcopy-msbuild)-generation

from arcade.

andriipatsula avatar andriipatsula commented on September 22, 2024

Thanks a lot!

from arcade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.