Patch `dotnet symbol-tool` to check completeness & availability of symbols about arcade-services HOT 16 OPEN

appears to be complete

Can you be more specific? I don't see anything related in https://github.com/dotnet/symstore/commits/main/src/dotnet-symbol, glancing over it. I would expect significant work there (or somewhere else, where?) to get anywhere close to being able to close this issue.

IMO someone should go through each bullet point and show how the automated system gets it done before closing this. Otherwise, we're at risk of having a flaky release pipeline without tracking already known flakiness and known fixes.

I'm highly skeptical of attempts to close this issue and other symbol validation issues because the problem has incorrectly been assumed to be solved multiple times in the past.

/cc @leecow

from arcade-services.

reopening because @dagood scared me. :)

from arcade-services.

I agree with @dagood. I would like to see a more systematic review/validation of what's being archived long term. I'm happy to help provide code that does validation of symbols.

I'm hoping that the Portable PDB work will (eventually) be finished this year, which will remove our requirement to archive Windows PDBs in favor of Portable PDBs only.

Might I suggest postponing this work (but not losing track of it!) until portable PDBs are supported by the dbgeng toolchain? (ETA later this year.) At that point making a push to ensure we are archiving the right kinds of symbols in the right places would be both timely and high value.

from arcade-services.

[Async Triage]: Seems like it should be done, but is it in this repo?

from arcade-services.

• Symbol completeness: given a .nupkg and a .symbols.nupkg (or .snupkg) we need to check that for each module in the .nupkg there is a symbol file in the symbol package.

This issue might be written shorthand and this is already known, but completeness isn't limited to modules, and most files have more than one associated file. For each file in the nupkg that requires some associated files to be indexed, all associated files should exist. I documented the associations I know of at dotnet/arcade#167 (comment).

(The temporary solution doesn't handle these.)

from arcade-services.

This issue came up again recently and I noticed this:

• Receive the path to a regular NuGet package and check if symbols for that package are available in both MSDL & SymWeb.
  ...
• Symbol availability: check that for every module in a .nupkg there is a symbol file in MSDL or SymWeb.

I want to point out that the first is correct, the symbols must be available in MSDL and symweb.

from arcade-services.

We are moving symbol validation to be part of the ring promotion activities. Moving to the appropriate tracking epic

from arcade-services.

Out of scope for dotnet/arcade#6418.

from arcade-services.

[Async Triage]: @adiaaida the same as dotnet/arcade#2519.

from arcade-services.

@mmitche - do you know if this is still an issue?

from arcade-services.

I don't think so? It's the standard tool, not one that we own, and the verification appears to be complete (spent some time looking at it yesterday)

from arcade-services.

thanks - closing

from arcade-services.

In the end, it could be closed for project scope reasons... but I think it's important to be clear about what is/isn't being validated so the release team, product teams, and highly impacted users (like Azure's snapshot debugging) can be aware and potentially push for more. What I'm trying to avoid is a surprise. 😄

from arcade-services.

Moving to the release epic so the v-team can dig in further. I'd like to understand the specifics and a general idea of the cost.

I know this was out of scope before @adiaaida, but let's make sure it's understand better before further determination.

from arcade-services.

Seems more like a production grade tool then Arcade specific infra tool (symchk replacement).
Related: symbol validation should also include Source Link validation. We have a starting point for that here:
https://github.com/dotnet/sourcelink/tree/main/src/dotnet-sourcelink but never got resources to complete it.

from arcade-services.

I have a tool which is meant as a symchk replacement which fully understands our symbol server story, including portable PDBs, validating Source Link, etc. However, I couldn't finish testing it and making it ready before I went on leave. I will be back in late august. Feel free to ping me then and we can put something together if a solution hasn't been found before then.

from arcade-services.