donejs / bitballs Goto Github PK

Add a "or register" link next to the login button that takes people to the "Create User" page.

Next:

• Change the routing so the /user page is now `/register.
• Instead of saying "Create User", it says "Register new user".
• Change the "Create" button to "Register".

• - move all Bookshelf models in to Models.
• - Make the first user that signs in the admin, not "[email protected]" #16 .
• - protect player service CUD methods unless someone is logged in
• - Make a "dev" folder in services. This is where services that are only supported in DEV might go.
  • A service that allows clearing all users.
  • A service that allows clearing all players.
• - Add any necessary methods (createListData) to data-url and can/map, and update can-connect's docs.
• - Write a test that does the following:
  1. In setup, clears all users, players, and logs the person out.
  2. Creates a user (which will be admin), logs them in, creates a player, is able to get that player.

We will need to review every module and identify and prioritize any problems with it. Problems may include:

• less than ideal code
• lack of tests
• lack of docs
• lack of demo page

If I try to create a user without an email or password, the server doesn't let me. But I should see the reason why.

The same thing should happen if you try to update a user's password.

• create a player without a height or weight
• click the edit icon
• enter a height and weight
• click cancel
• weight and height show the height and weight

MIght be related to #49

We might need the backup plugin from CanJS.

When the window's width is small, the navigation disappears.

Using brew install postgres.

Related to #71, if someone logs in with the wrong username / password, we should report this.

Similar to #51, we should make sure tournaments must have a date on the DB level. Then we should propagate that error to the client and show it next to the create button.

Good testing and dev workflows are one of the most important things we can provide. Lets get them in place asap.

Here's what's needed:

• - Figure out what tests are working and have public/src/test.js load them:

For example: http://localhost:5000/components/game/details/test.html currently passes. There will be other passing tests inside the src/components folder. Make sure they are all imported by public/src/test.js. Make sure src/test.html runs and passes all tests.

• - setup testee to pass locally

Something like this testee script should work. It should probably be in public/package.json. But then make sure package.json's test script runs public/package.json's test script.

• - setup CI

Setup continous integration as is shown in the PMO guide

Then make sure everyone knows and starts using it to submit pull requests!

• - setup CD

Finally, when master is merged, we want a deploy to heroku and firebase. The instructions for this are in the PMO Guide. As server-side rendering isn't turned on yet, you'll probably have to change index.html to point at firebase. I'd create a prod.html that loads local production files. This would make it easy for a developer to run in production with local production files.

At the end of this, we should be able to submit pull requests to master, have all the tests pass, and when we merge into master, push out the latest production code.

This can be done by using a jQuery filter.

Just like #56 , but when creating a game, the game does not show up under "Games" auto-magically like it should.

Make sure this isn't used. If it is not used, remove it.

related to #1

When linking to code, we need some way of specifying the tag version in one place. This will make it easy to keep the guide pointing at stable code.

The player and players fixtures currently conflict with each other and the player/edit tests had to be disabled for testee to set up testee for #11

https://github.com/donejs/bitballs/blob/master/public/app.js#L13-L31

Prevent a player from being created if he/she doesn't have a name.

This should be done by making it a required field in the DB by creating a migration that does it. Then the error from bookshelf should be sent back to the client. Hopefully the client can put it near the create button.

Also, if you try to update a player and remove the name, it should not work.

Currently, live-reload isn't working.

As this is a donejs app, we should make donejs develop start the node server, and live-reload correctly.

We aren't going to be using can-serve like place-my-order does.

Instead, we need to probably need to add a script to bitball's package.json that calls node index.js with an additional --develop option.

index.js needs to be updated to start live-reload. Here's how can-serve calls steal-tools live-reload: https://github.com/canjs/can-ssr/blob/master/bin/can-serve#L43. My guess is that @James0x57 did something similar for RoomPlanner.

I'm not a fan of having to spawn another process and having to depend on infanticide to kill it correctly. Findout from @matthewp if there's a way to programmatically. Perhaps a single node can only be one one process, hopefully not.

Bonus points if you can make this work in windows. Everything will have to work in windows eventually.

This should be an admin only feature.

For #46, #48, #51, and #53, we need to propagate server errors to display them on the client.

Since we're in the "make it work" phase and not the "make it pretty" phase, this should just include an error message by the submit button on the relevant forms.

Only a logged in admin should be able to create, update and destroy:

• tournaments
• games
• teams
• stats
• players

Anyone should be able to create a user. Admins should be able to do anything to a user. A user should be able to edit their info and delete themselves.

https://donejs.com/bitballs.html#section=section_Behavior

When a user registers, we should send them an email to verify their account.
We should have a /users page only visible by admin where they can see other verified users and mark them as admins.

Currently, the only user marked isAdmin is a user with an email address of [email protected] or [email protected]. This happens here: https://github.com/donejs/bitballs/blob/master/services/users.js#L26

To close this issue:

• - Change the service layer to check the number of users. If there are 0 users, that user is the admin. If there are more than one user, the user is not the admin. You can use Bookshelf's count to check how many users there are.

Rank isn't used. Remove it.

• - Write a guide outline
• - Review it with everyone

We should probably hide it or make it reset the form.

The components/game/details page loads youtube. This code should probably not run on the server.

split from issue #10

The conversation originated in #12. We shouldn't have to spawn another process to make live-reload work.

Write the management parts of the JS Checklist.

Steps to reproduce:

1. Clear your database ./node_modules/.bin/db-migrate down --count 5
2. Restore your db ./node_modules/.bin/db-migrate up
3. Go to #!user and create a new user. You will also be logged in.
4. Hit Logout. Refresh the page. You are not kept logged out.

No ajax request is actually made.

• remove db_client, app.json
• move bookshelf.js, is it possible to use database.json?
• move app.js into services
• rename post_install to install.js
• rename public/styles.less to public/app.less
• remove stylesheets folder
• remove .yo-rc, lang-logo.png, node.svg,
• Organize fixtures and models into final folder pattern. #121

Someone needs to do a review of the app and identify any bugs it currently has. Fixing these bugs with tests will be priority.

Here's what I think needs to happen to make server-side rendering work.

Make sessions work.

This site allows users to login and establish cookies. On future page requests, those cookies should be used by server-side rendering to render what a "logged in" user should see.

Everytime the client code runs, the app view model makes a request for the current session to the session service. This brings back the current user and if they are an admin.

This same code needs to run server-side. For example if a user goes to /players without having gone to any other page.

The problem is that while you can listen to /players with express, and even get the cookie, currently
there's not a good way to make the "client app running in node" see that cookie and make a request to GET /api/session with the same cookie information.

This should all happen automatically without bitballs really having to change code.

There are two things needed to make this happen.

• - 1. Make sure the cookies from the incoming express request object are put on the "virtual DOM".

Somewhere here https://github.com/canjs/can-ssr/blob/master/lib/index.js#L55 we need something like:

doc.cookie = request.getHeader("cookie")

• - 2. Make sure XHR requests in the "client app running in node" include the current document's cookies.

Somewhere in https://github.com/canjs/can-ssr/blob/master/lib/middleware/xhr.js we might need something like:

XMLHttpRequest.prototype.send = function(){
  // add document.cookie as a header

}

Turn on pushstate

• - public/src/app.js should be importing can/route/pushstate/.

Setup ssr

Somewhere in index.js we need to setup the pushstate service. To keep things organized, it would be nice if the code that setup ssr was actually in a ssr.js file in this folder: https://github.com/donejs/bitballs/tree/master/services that was imported by index.js.

Importantly, we should only be rendering what the "client app running in node" understands. @daffl and @matthewp should know how to set this up.

Make the youtube embed a no-op

The components/game/details page loads youtube. This code should probably not run on the server.

Write a rough draft of guide, with an emphasis on identifying the parts of Bitballs that need to be perfect.

On pages like "Players" and "tournaments", show a nice "No data" message when the list is empty.

Make a script that generates the documentation and publishes it to a gh-pages branch.

This makefile serves as a good example.

The script should:

• checkout gh-pages
• run documentjs
• force add the docs folder and selective parts of node_modules needed for demo and test pages to run: can, jquery, steal, can-connect, there's probably a lot more.
• make a commit and force push it to gh-pages
• check back out master or better would be the old working branch
• delete gh-pages

This should run with CD and be pushed out every time someone merges into master.

The YouTube URL form actually only works if you paste a youtube key like y5sdfa834lJ. This key is what should be stored in the DB, but we should allow people to paste either the key or the URL and it works.

Currently there's no way to delete a stat.

You should be able to click one and delete it.

There might be a problem with can-connect.

If you enter a date in the New Tournament Date field and hit "Create" twice quickly, only one tournament shows up despite making two requests.

Likely this is due to .save() being called twice on the same instance.

This is probably fixed by using {{isSaving}} to disable the create button.

Steps to reproduce.

1. Restart your server so you are logged out.
2. Login as a user.
3. Go to #!user and enter a new password.
4. In the "network" tab, you'll notice a 404 error.

When I created a team, I had to refresh the page to see it in the list of teams.

Currently, the players page Weight and Height inputs default to showing 0 instead of their placeholder values as is shown below.

This almost certainly has to do with a type converter changing the empty string input.value into 0.

We might need a good solution for this, even adding a feature to CanJS.

I don't think these modules are used anymore. If not, remove them.