doncatnip / kanone Goto Github PK

When #14 is done, tagging needs to be reworked as right now nested tag parameters work as follows:
o = MyComposedValidator(taggedValidator_validationParameter=42)

with under_score naming this would not be possible.

Example:

before

@messages\
    ( type="Invalid type (%(value.type)s), must be a integer"
    , convert="Could not convert %(value.type)s to integer"
    )

after

from gettext import gettext as _

@messages\
    ( type=_("Invalid type (%(value.type)s), must be a integer")
    , convert=_("Could not convert %(value.type)s to integer")
    )

I'found that Match validator seems to be copy pasted ? Am I right ?

...
def setParameters(self, required, ignoreCase=False):
...

"required" adds misunderstand in validator uses, maybe it will be better to change to something more meaningful ? like expression, pattern or s.e.

/kanone/validator/check.py
from:
max="Value cannot have more than least%(max)i elements/characters (has %(len)s)"

to:
max="Value cannot have more than least %(max)i elements/characters (has %(len)s)"

missing space between "least %(max)i"

Refactor kanone to use under_score instead of camelCase for variables, parameters and function names

the code

s2 = (
  't1', String() & Len(max=9),
)

s = Schema(
  *s2
)

c2 = {
  't1': u'Скушай яблоко',
}

c = s.context(c2)

Traceback (most recent call last):
File "utils.py", line 94, in
result = c.result
File "build/bdist.linux-x86_64/egg/kanone/lib.py", line 222, in result
return self.validate()
File "build/bdist.linux-x86_64/egg/kanone/lib.py", line 331, in validate
result = self.validator.validate( self, self.value)
File "build/bdist.linux-x86_64/egg/kanone/validator/core.py", line 116, in validate
return self.on_value( context, value )
File "build/bdist.linux-x86_64/egg/kanone/validator/schema.py", line 69, in on_value
return self.on_value( context, value )
File "build/bdist.linux-x86_64/egg/kanone/validator/schema.py", line 174, in _createContextChilds_on_value
res = context( key ).result
File "build/bdist.linux-x86_64/egg/kanone/lib.py", line 222, in result
return self.validate()
File "build/bdist.linux-x86_64/egg/kanone/lib.py", line 334, in validate
self.error = e
File "build/bdist.linux-x86_64/egg/kanone/lib.py", line 250, in error
extra['value'] = str(value)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-5: ordinal not in range(128)

since Blank is restricted to the String datatype only maybe on_blank should not be a thing - and if we want to keep it, a string containing whitespaces should count as blank too.