I realize this is a change to the API but it would be nice to have all return types inherit from BittrexResponse so we didn't have to try catch everything and do error handling in catch blocks, ie, we could just take Success? Anyway, love the API, works great.

To use the public api, api key and secret are not needed.
Therefore, it should not be necessary to provide it.
The implementation should check if a key and secret were provided, and if not, throw an exception if an api call would be made that needs them.

The APIs like buy limit and sell limit don't pass the API key.
I changed in my clone. I couldn't request for the pull.

I think there is an issue with the apisign when you use the account API's. For instance, I have no problems with your code but

var xx = await this.bittrex.GetBalances();

blows with "INVALID_SIGNATURE" even though the nonce and hash are there. I read somewhere that the hash must be generated against the entire URL with all the parameters on it. Could this be the issue?

Other than that the API work great thus far, but I really need the account API's to work

• If the correct exception is thrown if the returned json cannot be converted
• If the return value is an unsuccessful ResponseWrapper with the correct message
• If the methods that need authorization work correctly if valid authorization is given
• If a useful exception is thrown if the response json is malformed (cannot be converted to BittrexResponse)

BittrexOrderSimulation is a Bittrex api implementation that simulates all aspects of orders, so that it is possible to test trading algorithms without actually executing them.
The last bit of simulation, continuously checking if the open orders are executed in another thread, is what this issue refers to.

I think the title says it all...
Says that it has timed out, but seems to do this really quickly. I imagine this would take a little while to return.

I have gotten GetMarkethistory to work, and am Implementing similarly.

Thanks

Hi,

unable to open in VS 2015, Shows

error : The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the <Project> element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.

While the v2.0 API isn't offically supported yet, there is some good stuff in there and it has already been reversed engineered here.

Is this something you would want to add already? I can do it for you if you'd like as I am looking into them right now.

Can you help?
I keep getting this error, i havent been able to connect the client yet.

System.IO.FileNotFoundException: 'Could not load file or assembly 'System.Net.Http, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.'

Should be nice have this features

PD: Great job

is this based on v1 or 1.1?

Hi there,

I just implemented the project files into my solution. My WPF application calls the bittrex api with a valid public and private key - with all the permissions except withdraw.

When it hits line 108 of Bittrex.cs, nothing else happens. No exception, no returns. It seems like it keeps waiting for a response for ages.

What am I missing? Anyone else with this problem?

At the moment exceptions are almost completely ignored.
Especially exceptions that deal with request errors would be important to handle.

Hey, many thanks for opensourcing this project!
Bittrex provides an undocumented websocket API based on Signalr. Do you plan to include a client for it?

Here's an example implementation: https://github.com/JKorf/Bittrex.Net/blob/master/Bittrex.Net/BittrexSocketClient.cs

Cheers,
Wojtek

Travis CI is configured, but there is an issue with dotnet sdk 2.0.3 that needs to be resolved:
travis-ci/travis-ci#8778

When i try to use your code I get an exception.

I have a forum with a button that does the following.

Any ideas what could be the problem? I have tried this from my work and home network. I thought it could be the home ISP but work network gives the same issue.

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Text;
using System.Windows.Forms;
using BittrexSharp;

namespace WindowsFormsApp1
{
public partial class MainForm1 : Form
{
public MainForm1()
{
InitializeComponent();

    }

    private void button1_Click(object sender, EventArgs e)
    {
        try
        {

            var apiKey = "......"; //removed for securty
            var apiSecret = "....."; //removed for securty 
            var BittrexAPI = new Bittrex(apiKey, apiSecret);


            toolStripStatusLabel1.Text = "Balance:" + BittrexAPI.GetBalance("BTC").ToString();
        }
        catch
        {
            toolStripStatusLabel1.Text = "Diconnected to BittrexAPI";
        }
    }
}

}

On my machine, decimals are noted with comma's instead of dots. Comma's get URL-encoded, that means an invalid rate value is sent to bittrex and that causes the RATE_NOT_PROVIDED error message.

Simple fix here is to replace the comma's to dots in the param values. I'll create a PR shortly.