dominiccooney / cache-polyfill Goto Github PK

This method is shown in the README but doesn't exist on the cachesPolyfill object returned from the import. I don't think get is in the spec, but I'm not 100% so have opened an issue instead of a PR that implements get.

The Blink team is trying to ship the Cache API on the global scope (http://crbug.com/439389).

Do we need to change anything in the polyfill to prepare for this eventuality?

cc/ @jakearchibald

Y'all be fance with your --experimental-javascript-features 'n shit:

https://github.com/coonsta/cache-polyfill/blob/master/lib/cachedb.js#L12

'Causes polyfill to blow up on stable-channel Chrome (which I'm using to debug for reasons that are HORRIBLY boring).

1

if (!Cache.prototype.add) { ....

It will throw an exception. You'd check the Cache before

2

return Promise.resolve().then(function() {...

It can be replaced with:

return new Promise(function() {...

3
Where's matchAll, match, put, delete, keys ?
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

4
window.fetch and URL are not implemented yet in the most browsers. You'd mention it.

5
Do you see https://github.com/slightlyoff/ServiceWorker? Why not use the one?

Obsolete polyfill for the ServiceWorker cache API. Chrome 46 and Opera 33 support addAll now.

I think this is wrong since addAll() gets new algorithm soon. I am not sure I can properly rephrase that sentence, so just creating an issue instead of PR.

Plus, you have to publish v4 to NPM :-)

Looking at the source, I realize this may not be the goal of this project.

But, I came to this project hoping to find a Cache polyfill for node.js. In node.js (at least v8.11.1) there is no Cache object, and I could really use this object.

So I realize this is a big stretch... is there an interest for this project to build a full Cache implementation for node?

I guess this project can be marked as deprecated now that https://code.google.com/p/chromium/issues/detail?id=427652 is fixed and shipping in Chrome 44.

My bad, Cache#addAll won’t ship until Chrome 46. Still, the Cache#add polyfill can be removed.

I think that It will be useful to add a callback function (function(response)) as parameter to the cache.addAll(requests,callback), this allow get more control over the responses and decide which will be cached, i.e. if response.status < 400 not store on cached.
This callback could return true/false to control what response is valid to be cached.
Thanks, great work,

By error a had duplicated resources but the cache not show any error (console, ...). I saw that the cachedb check this and throw an exception TypeError. I changed the addAll to notify about it:

CacheProto.addAll = function(requests) {
  requests = requests.map(castToRequest);

  Promise.all(
     requests.map(function(request) {
         return fetch(request);
    })
  ).then(function(responses) {
    return cacheDB.put(this._origin, this._name, responses.map(function(response, i) {
      return [requests[i], response];
    }));
  }.bind(this)).catch(function(err){ 
      console.log(err);
  });
};

Once time a fix the duplicated I detect that Response don't has asBlob property and changed
return item[1].asBlob ? item[1].asBlob() : item[1].body.asBlob();
to
return item[1].blob ? item[1].blob() : item[1].body.asBlob();

I hope that will be right and helpful.

As soon as Chrome 46 (check) and Opera 33 (soon now) are out, this polyfill isn’t needed anymore. \o/

I tried, and couldn't get the 'ignoreSearch' option working at all.
For reference: https://developer.mozilla.org/en-US/docs/Web/API/Cache/match#Parameters

May u should merge this PR from @QingLeiLi to avoid this error.

(anonymous function)
internal:///Users/vuchan/Development/WorkSpace/***/node_modules/[email protected]@serviceworker-cache-polyfill/index.js:19

(function() {
> 19 |   var nativeAddAll = Cache.prototype.addAll;
  20 |   var userAgent = navigator.userAgent.match(/(Firefox|Chrome)\/(\d+\.)/);
  21 | 
  22 |   // Has nice behavior of `var` which everyone hates

The link mentioned in the README to download serviceworker-cache-polyfill.js currently 404s.

Great polyfill.

Will this cache polyfill allows my a PWA app to work in the older browsers such as IE10 or IE11? My goals is to find a way via the polyfill (or any other ways) to either turn-off the Service Worker caching when its IE, or help my app to work without breaking. I am using sw-precache to create the Service Worker.

Thank you

It seems 404 in npm.
https://www.npmjs.com/package/serviceworker-cache-polyfill