domdfcoding / circuitpython-mfrc522 Goto Github PK

I am trying to convert this library to work on an WS12850S that allegedly has the exact same software interface as the MFRC522 but using an I2C interface rather than SPI.

To do this, I replaced two functions:

    def _wreg(self, reg: int, val):
        data = bytearray([val])
        self.i2c.try_lock()
        self.i2c.writeto_then_readfrom(self.i2c_address, bytes([reg]), data)
        self.i2c.unlock()
        return data[0]

    def _rreg(self, reg: int):
        data = bytearray(1)
        self.i2c.try_lock()
        self.i2c.writeto_then_readfrom(self.i2c_address, bytes([reg]), data)
        self.i2c.unlock()
        return data[0]

Looks reasonable so far, for writing single bytes. I'm not sure the readback from _wreg is meaningful.

This kind of works, but I'm a little concerned about this:

    def _tocard(self, cmd: int, send):
       ...
        for c in send:
            self._wreg(0x09, c)

I think the intent there is to write a string of bytes (send) but in I2C I think I would want to do that as a single transaction, similar to what I did with my _wreg but taking an array of values rather than just a single byte. Does this make sense? Do you agree, and do you see other things that would need modification?

Finally ... if this works, is it worth abstracting out the physical interface so that we can re-use your code but select the interface (SPI or I2C) like:

	rdr = MFRC522( spiInterface )
	rdr = MFRC522( i2cInterface )

and both those interfaces include _wreg, _rreg, and possibly _tocard (and maybe more?)

I tried this project, but at first I got the error "AttributeError: 'module' object has no attribute 'SCK'".
Therefore, I directly specified the pin number on line 15 of read.py like "rdr = mfrc522.MFRC522(board.GP14, board.GP16, board.GP15, board.GP22, board.GP14)".
Then, the following error occurred.

Traceback (most recent call last):
File "", line 54, in
File "", line 15, in do_read
File "mfrc522.py", line 34, in init
ValueError: GP14 in use

How can I fix this?