dolejska-daniel / riot-api-league Goto Github PK

Hey I really enjoy your work and i want to know if you will update the match V4 to V5 ?

https://twitter.com/RiotGamesDevRel/status/1382471243744518145

Thanks !

Currently riot adds properties to Dto very often.
When they add some, this driver don't work because of "Property *** does not exist" error.

Describe the bug
Hello.
I am using asynchronous ReactPHP in my application and would like to use your code to access to Riot API, but it seems it block I/O and is completely non-asynchronous despite the presence of methods.

To Reproduce

	$logger->info('before');
	
	$api
		->nextAsync(function($result) use($logger){
			$logger->info('success');
		}, function() use($logger){
			$logger->error('fail');
		})
		->getChampionRotations()
	;
	
	$logger->info('before commit');
	
	$api->commitAsync();
	
	$logger->info('after commit');

Expected behavior

[13.06 12:37:53][INFO] before
[13.06 12:37:53][INFO] before commit
[13.06 12:37:54][INFO] after commit
[13.06 12:37:54][INFO] success

Current behavior

[13.06 12:37:53][INFO] before
[13.06 12:37:53][INFO] before commit
[13.06 12:37:54][INFO] success
[13.06 12:37:54][INFO] after commit

Server:

• PHP version: 7.4.14
• react/react version: 1.1.0
• dolejska-daniel/riot-api-league version: 1.0.1

Thanks.

Hello,

Thanks for your library, it'll allow me to drop my fork of an unmaintained LoL api client.

I wanted to gather more information on how to set the cache provider but all your links refer to the wiki and when being clicked on we're returning on the readme.

Sames goes if you click on Wiki section through github.

Hi, love the library, use it for many projects, currently doing a project for tracking match history.

However, I noticed that when using the matches API, it returns really old matches, like almost 300 days old, while every other region seems to function good.

Is this a known bug?

requiredAlly property does not exists on StaticItemDto for Ornn's items.

The variable is declared but when im trying to get the value it returns "".

Hiya, firstly thank you for making this library its going to help me a lot :)

So i had a question/request with regards to the rate limiting, is it possible to set a manual rate limit? sadly i'm a novice so i can't find where the check is happening myself to edit it so if i'm missing a really obvious line somewhere i apologise >.<

The reason for this is wanting to set the limit of the library to say 80% of my max so that there is still some overhead left for users to be able to still make calls where required on a website for adding new summoners to my database with the library mostly running in the background to help update data that i store

using a summoner who DO NOT EXISTS the output is 👍
$summoner = $api->getSummonerByName($summonerName);

Fatal error: Uncaught RiotAPI\Base\Exceptions\ForbiddenException: LeagueAPI: Forbidden. Data not found - summoner not found in /home/xxx.cloudwaysapps.com/fxzmmrqygx/public_html/vendor/dolejska-daniel/riot-api-base/src/Base/BaseAPI.php:1127 Stack trace:
#0 /home/140198.cloudwaysapps.com/fxzmmrqygx/public_html/vendor/dolejska-daniel/riot-api-base/src/Base/BaseAPI.php(1063): RiotAPI\Base\BaseAPI->processCallResult()
#1 /home/xxx.cloudwaysapps.com/fxzmmrqygx/public_html/vendor/guzzlehttp/promises/src/Promise.php(204): RiotAPI\Base\BaseAPI->RiotAPI\Base\{closure}()
#2 /home/xxx.cloudwaysapps.com/fxzmmrqygx/public_html/vendor/guzzlehttp/promises/src/Promise.php(153): GuzzleHttp\Promise\Promise::callHandler()
#3 /home/xxx.cloudwaysapps.com/fxzmmrqygx/public_html/vendor/guzzlehttp/promises/src/TaskQueue.php(48): GuzzleHttp\Promise\Promise::GuzzleHttp\Promise\{closure}()
#4 /home/xx.cloudwaysapps.com/fxzmmrqygx/public_html/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php(158): GuzzleHttp\Promise\TaskQueue in /home/140198.cloudwaysapps.com/fxzmmrqygx/public_html/vendor/dolejska-daniel/riot-api-base/src/Base/BaseAPI.php on line 1127

The answer is correct but it stop working

P.s.
Excellent work!!

Hello Daniel !

I want to know if you plan to update ParticipantDto with the new "challenges" property , because if i try to access the "challenges " property i get this error

Trying to access undefined property 'challenges' on object

and my quick fix for that was adding the following code at the end of the ParticipantDto.php , it's working for now , but i don't know if it is the proper correction.

`	/**
	 * Available when received from:
	 *   - @see LeagueAPI::getMatch
	 *
	 * @var bool $win
	 */

	public $challenges;
`

`

Thanks !

Is there any possibility to get runesId from a participant of a match? Match->Participants[0]->stats->runes returning null.

Been trying to pull up getMatch but does not return any values, gives undefined property depending on which object is used.
For example $match2 = $api->getMatch((string)'EUW1_5599108990'); and then echo $match2->participants;

There seems to be hardcoded IRegion::AMERICAS in many methods in LeagueAPI.php.
Examples: L1901, L1946