Refs dojo/widgets#35

Given out current thinking on a11y, we should evaluate todoMVC to see what work would need to be done to meet our guidelines.

We should have functional (and a level of unit tests) for TodoMVC

#23 assessment done. Lets use this issue to track the actual work.

In order to for dojo/widgets#22 to be fully resolved, we will need to refactor todo-mvc and monster-cards to utilise the functionality in PR dojo/widgets#40.

The versions of Maquette and Immutable are pinned for Monster Cards:

{
  "dependencies": {
    "immutable": "3.8.1",
    "maquette": "2.3.2"
  }
}

They should be more properly semvered. Currently this is causing the following warning on npm install:

npm WARN [email protected] requires a peer of maquette@^2.3.5 but none was installed.

Non-functional requirement

• The home page should be the first page displayed after the user has logged in.
• The home page should consist of a header, main section and footer.
• The header should not scroll out of view when the page is scrolled, but the main section and footer should scroll if they extend below the fold.
• If the height of the main section is less than the viewport height, then the footer should align to the bottom of the page (sticky footer).

Around beta, we should make a performance test available for comparison, either a fork of https://github.com/evancz/todomvc-perf-comparison or https://github.com/kriszyp/todomvc-perf-comparison

Implement the seen with cards

Change the monster app implementation to use widgetBase and d

• use d
• use widgetBase
• update tests
• remove unused files
• remove unused tests

Given
  standard user
  successful login
When
  the user selects a card from the cards page (monsters or momentum pages)
Then
  output: 

• The user should see the details for the selected card on a page devoted entirely to the selected card.
• The details should include the card's title, description, large format image of the character, and the details of what the card does.
• 'Last seen with' section should be displayed with medium sized card images.
• Links to twitter and facebook should be displayed

  post condition: you should be able to get back to the home page from the card detail page.
   If the user was on a certain 'page' of results on the home page, then going back to the home page should take the user back to the last viewed 'page' of results.

TBC

Implement a basic dojo deploy cli task for the example apps, when supported in cli.
In the meantime, implement sitepen specific deploy task to put on demo servers.

Outside of the MemoryStore which was ported from another repo, the rest of the source code has exactly 2 comments, both of which are /* I suspect this needs to go somewhere else */ and don't follow the convention of /* TODO: ... */.

While things are named logically and TypeScript is somewhat self documenting, the total lack of comments for an example application is not a good idea as those looking to "judge" how our architecture would not be impressed.

ddddd

https://drive.google.com/drive/folders/0B_iJTK6sYbwKeEwyR2RSTWdjSkU / 01_home.png

Until there is a resolution on how to build an application that presumes to load modules using AMD style MIDS we are going to remove the usage of this functionality from our example applications.

Build the app:

• any perf work (concat, minification..)
• generate sourcemaps
• build layer file

Refs dojo/widgets#35

Enhancement

Package Version: Latest

Description

extend has been deprecated and replaced with override, occurrences need to be updated.

Related to #16

We should figure out if reusing the TodoMVC tests makes sense for us maintaining TodoMVC. It is a totally separate toolchain to what we already have integrated into the repo. While they are canonical tests, they may are may not be the sorts of tests we need to utilise TodoMVC as a proving ground to detect regressions in our other packages.

So the suitability of the tests and the ease of integrating and using them should be considered.

Update the project structure for stylus files to have the styles along side widgets and a main.styl looking after all the imports.

Our examples should utilise strictNullChecks and noImplicitThis TypeScript compiler features.

• - todo-mvc
• - monster-cards
• - dojo-cli-example

• convert to TS2
• implement strictNullChecks
• implement noImplicitThis

All code should be release under BSD 3 Clause (New BSD). The LICENSE file is missing and the license property in the package.json is incorrect.

No need to re-name id to cardId each time we use a card

We should have our examples integrated with CI.

This is the Epic for different user stories related to the Todo MVC example for Dojo 2.

The app needs to have a proper build step that produces a production version that is compressed, minified (maybe inlined) and obfuscated.

Given
When
the user enters filter criteria
Then
[output] the user should be presented with a list of cards that match the filter criteria
[post condition] clearing the filter criteria should remove any filtering of the result set of cards.

Steps to reproduce (tested in FF latest and Chrome latest):

1. Add any number of to-dos.
2. Mark all to-dos as completed.
3. Click "Clear completed".
4. Add more to-dos.

Expected result:
The new to-dos should be rendered as part of the to-do list.

Actual result:
The new to-dos are not rendered, even though the footer text (e.g., "1 item left") is updated.

We should be able to production-ify our Todo-MVC application

See dojo/meta#62 for details.

The sprites are 200kb and 2.1mb respectively, these should be optimised.

Work to go through any bootstrap process and render basic home page with header/main/footer placeholder divs.

In todo-mvc createFocusableTextInput we are using setTimeout(fn, 0) to set the focus. This can be a performance issue on a number of platforms and there are better ways to cause something to run at the end of the turn. In particular, this is a micro-task and should then use dojo-core/queue#queueMicroTask.

As a User
I want to be presented with a list of cards
So that I can select a card to play in the game.