The templates used to create an app need to be updated for version 3. Specifically, they need to point to the new @dojo/framework package instead of the individual core, has, i18n, widget-core, routing, stores, and shim.

Review the generated API documentation for cli-create-app at http://dojo.io/api/. If any of the information is not accurate, please make the necessary adjustments to the API documentation within this repo.

Enhancement

Now that @dojo/cli-build-app has been released with the intention of deprecating @dojo/cli-build-webpack, the package.json template should be updated to use @dojo/cli-build-app instead of @dojo/cli-build-webpack. Further, the following packages should also be upgraded as well:

• @dojo/i18n
• @dojo/widget-core
• @dojo/widgets
• @dojo/cli-test-intern
• @dojo/test-extras

Enhancement

The template application should have tsx enabled by default in line with the tsconfig.json in the examples:

https://github.com/dojo/examples/blob/a386aa2332ea37c29f33c329ff5254322f33c511/todo-mvc-tsx/tsconfig.json#L5-L6

Including "types": [ "intern" ] resolves the typings issues that occur when upgrading to intern 3.4.1 using the dojo build/dojo test CLI - So we should update these.

** Enhancement**

Update to create Dojo 7 apps.

Need to update for the changes to the dojo2 packages to use @types and also dojo build

The latest intern 3.4.1 does not require all the typings previous versions did. These can be removed to prevent the duplicate typings error.

Enhancement

Add scaffold dojorc to the application template.

As part of dojo/widgets#224 we will be removing stylus from the build step. As such, create-app will need updating to accommodate a main.css file instead.

It takes a while to install the node modules during creation of an new application, although we do not want the default output from npm we should provide the user with some feedback (so they do not think that is has broken)

Building a freshly-generated application results in the following error messages:

ERROR in multi src/main
Module not found: Error: Cannot resolve 'file' or 'directory' testApp\src\main.styl in testApp
 @ multi src/main

ERROR in multi src/main
Module not found: Error: Cannot resolve 'file' or 'directory' testApp\src\main.ts in testApp
 @ multi src/main

Not sure if we want to change what files the build expects (src/main.styl seems odd) or add these files to app creation.

Enhancement

At the moment our README is pretty much non-existent. It would be nice if the README included instructions on how to dev, build and test as well as any other useful cli information.

Add a hello world example for the skeleton app, which should include a custom widget with children.

Problem

We have created several tutorials based on the code produced by dojo create alpha.11.
Now that the boilerplate produced is out of step with the tutorials, we can either update all the tutorials to match the latest boilerplate, or we can introduce a way to produce different types of boilerplate.
The drawback with updating the tutorials, is that the generated is always a moving target and so this activity may have to be undertaken many times.

Bug / Enhancement

If you create an app and run npm install it complains that intern has critical issues. An audit suggests updating to 4.2.0.

Enhancement

We should bump the @dojo/widgets version installed via create app so that users get the latest theme keys.

The application created by cli-create-app uses Intern 3. Update it to use Intern 4. The following dependencies need to be bumped:

• cli-test-intern ~0.2.0
• cli-build-webpack ~0.2.0

The code produced has no comments. If a new user runs create then I think the code generated should be very explicit in its intentions, e.g.

const classes = this.classes(
  css.hello,
  this.properties.stranger ? css.upsidedown : null
);

might be better written as:

// always apply the 'hello' class
const classesToApply = this.classes(css.hello);

// if stranger is true, then also apply the upsidedown class from our css
if( this.properties.stranger) {
  classesToApply.push(css.upsidedown);
}

We can either add add comments to the generated code, or we could write a tutorial that explains the generated code, and keep it in sync with any changes to this repo. The advantage of the tutorial approach is that the generated code would also work well for experienced users.

In working through the tutorials, we should make sure we're keeping the generated app current, specifically the versions of intern, remap-istanbul, the version of ts (in both package.json and tsconfig.json, which by the way are not the same at the moment, one is 2.1.4 and the other is 2.0.3), and remove extra-rxjs from typings.json.

Now we have unpinned the dojo deps, we should have unpinned deps in the generated package.json. I also plan to remove the @dojo/stores dep, as it is not used, and replace with a @dojo/widgets dep. I'll ammend the HelloWorld.ts file to use a @dojo/widgets/Button/Button so that we can demonstrate using a dojo widget.

Bug

When app name is not properly specified, instead of responding errors, the application proceeds to createDir() which results in the following error:

EACCES: permission denied, mkdir '/src'

For example, running one of the following commands will reproduce this issue: (args.nameis empty string in both cases)

• dojo create app -n
• dojo create app -name foo

Package Version: v2.0.0-beta1.2

The template package.json for the created application should probably use the next dependency tag.

Remove Immutable and RxJS from the app templates package.json and typings.json

Also migrate from @dojo/widgets to @dojo/widget-core and add @dojo/i18n to the dependencies.

Bug

We should change the logo here https://github.com/dojo/cli-create-app/blob/master/src/templates/src/img/logo.svg as it currently has the number 2 in it and we are now on version 3 😄.

The reference path for typings installed as part of the create app is not correct, in the typings/index.d.ts file the references get generated with an extra typings directory.

<reference path="typings/globals/extra-rxjs/index.d.ts" />

but should be

<reference path="globals/extra-rxjs/index.d.ts" />

Enhancement

We have patterns for routing, pwa, build time renderering, code splitting and stores that we should demonstrate in the application that is created by default.

Perhaps keep a very minimal skeleton as an option.

• summary
  • The create app command for the dojo cli -> The create app command for @dojo/cli
• features
  • installed build command is cli-build-app, not cli-build-webpack
  • start app running dojo build --mode dev --watch memory --serve
  • build tests with dojo build --mode test, they're built to output/test
  • dojo build creates output/dist

question?
Do we want to include this in the features as we already have the above info in the newly created app's readme?

Template Literal is fastest, smallest and simplest template engine, because it use JS's literal template feature.

It's 55 times faster than EJS, and it also use less CPU and RAM ressources, so it may be a good idea to use it instead of EJS 😀

@rishson commented on Wed Mar 22 2017

We should remove the dojo/stores dep from the boilerplate package.json. Whilst the dojo/stores dep is OK in itself, it has a peer dep of dojo/compose so will raise warning on running dojo create if compose is not found.

Enhancement

When we have delivered dojo/cli-test-intern#39 we should refactor the tests to use the widget test harness.

Enhancement

The example should be extended to demonstrate the recommended structure for building an application (to date) and not just a widget.

This would include adding a container App.ts and also adding some functionality using Themeable, properties passing and an example event handler.

Enhancement

We can remove this and the tests: https://github.com/dojo/cli-create-app/blob/master/src/renderFiles.ts

We can now use the helper method provided by the CLI! dojo/cli#180

Test failure on Windows,

× config - Should strip .template from fileName (0.015s)
AssertionError: expected '/foo/bar\\.gitignore' to equal '/foo/bar/.gitignore'
  at Function.assert.equal  <node_modules\intern\browser_modules\chai\chai.js:2277:10>
  at Test.Should strip .template from fileName [as test]  <tests\unit\config.ts:27:9>
  at <node_modules\intern\lib\Test.js:191:24>
  at <node_modules\intern\browser_modules\dojo\Promise.ts:393:15>
  at runCallbacks  <node_modules\intern\browser_modules\dojo\Promise.ts:11:11>
  at <node_modules\intern\browser_modules\dojo\Promise.ts:317:4>
  at run  <node_modules\intern\browser_modules\dojo\Promise.ts:237:7>
  at <node_modules\intern\browser_modules\dojo\nextTick.ts:44:3>
  at _combinedTickCallback  <internal\process\next_tick.js:73:7>
  at process._tickCallback  <internal\process\next_tick.js:104:9>

Add a lang attribute to the html tag in the index.html template.

Bug

When running dojo build with a newly created project, errors occur in the build related to the typings for Chai

Package Version: 0.2.0

Currently the WIP implementation of cli-create-app scaffolds a tslint.json and a .editorconfig file. Do we think these should be part of the scaffolding of a new Dojo 2 app?

Given this is the first interaction a new user will have with Dojo 2, I don't think we should presume that they know and/or are comfortable writing stylus.
I think we should create app.css and include some basic styles in plain old CSS.

tests/unit/App.ts creates a spy for the setProperties function of the HelloWorld class. This method has been renamed __setProperties__ and, as a result, the created test suite fails to create the spy.

Bug

An error occurs when running dojo create -n my-app.

⠋ npm install(node:41307) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: ENOENT: no such file or directory, open '....../.nvm/versions/node/v6.9.1/lib/node_modules/@dojo/cli/node_modules/@dojo/cli-create-app/templates/.gitignore'

It does not prevent the command from completing.

I update my cli and cli-create-app to 5.0.0, then I use dojo create app --name myApp create a dojo app, then run in dev mode. But the “Home”,"About" and "PROFILE" displayed at the left, not displayed at right.

I can not upload image to “github.com”.

Bug

Package Version: 5.0.1

Expected behavior:

The src/index.html files in projects generated with cli-create-app is missing a <meta charset> tag as well as a dir attribute on the <html> tag.

Actual behavior:

The html[dir] attribute should be present and default to "ltr" and the charset meta should be present with a utf-8 value.

Description is Scaffolds a new command but should be Scaffolds a new app

Enhancement

We should run dojo init after npm install to create a .dojorc rather than manually creating the file/copying in create-app. This will future proof us for any other things that @dojo/cli needs to generate in the .dojorc by default.

Enhancement

The template of the tsconfig.json should use "strict": true and eliminate the redundant compiler options.

When generating an application, tests/all.ts and tests/app.ts are not created as expected.

Is it worthwhile adding meta files such as .gitignore to the app template?

Enhancement

Dojo CLI applications should be easy to run. npm scripts are easy for people to use who may not be familiar with the Dojo CLI and can run dev dependencies that don't need to be installed separately (i.e. globally)

Expected behavior:

An application generated using cli-create-app should be able to be installed an run easily when git cloned. Ideally, some npm scripts should be runnable immediately after install.

Actual behavior:

A cloned repo generated from the cil-create-app requires the domo cli to be installed to run.

Code

Current template

Suggested Template

{
  "name": "<%- appName %>",
  "version": "1.0.0",
  "scripts": {
    "dev": "dojo build --mode dev --watch memory --serve",
    "build": "dojo build",
    "test": "dojo build -m test && dojo test -a"
  },
  "dependencies": {
    "@dojo/framework": "~3.0.0",
    "tslib": "~1.8.1"
  },
  "devDependencies": {
    "@dojo/cli": "^3.0.0",
    "@dojo/cli-build-app": "~3.0.0",
    "@dojo/cli-test-intern": "~3.0.0",
    "@types/node": "~9.6.5",
    "typescript": "~2.6.1"
  }
}

If there is an error during npm install it is not reported correctly and continues to try and install typings.