Git Product home page Git Product logo

rbtv-api's Introduction

Rocket Beans TV API

Simple Python wrapper for the RBTV JSON API. See https://github.com/rocketbeans/rbtv-apidoc. Authorization is not implemented yet. That means all endpoints which require authorization (like subscription management) don't work yet.

rbtv-api's People

Contributors

dobatymo avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

rbtv-api's Issues

Improvement suggestions

Hi, thanks for this nice project!

I have some improvement/style suggestions:

  • Use four space indentation instead of tabs (https://www.python.org/dev/peps/pep-0008/#indentation). Probably even use black for code formatting and add a pre commit check.
  • Type hints can be made inline. Imo. this looks neater than specifying the hints it in an separate comment.
  • There are no tests. Implement a testsuite based on unittest or pytest and run it as an github action.
  • There are no examples in the readme. Add a few.
  • Some more, but it would be too much for this issue.

The changes wouldn't affect the user interface much. However, they would touch almost all of the existing code. To get an idea how the code would look like, you can take a look here. I thought about creating a separate repo, but maybe we can rather bundle the efforts. Let me know if you are interested or if you want to keep the project as is.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.