using the EDITOR environment variable about dnote HOT 6 CLOSED

The reason for defaulting to vim was that commands to launch some editors return immediately, unless a flag is passed (atom vs atom -w).

We can probably default to EDITOR, if we cover editors that require flags as much as possible. I am not totally sure what the best solution is. Any ideas on the trade-off welcomed.

In the meantime you can change the editor following these steps https://github.com/dnote-io/cli/wiki/Guide#change-editor

from dnote.

My two cents: set vim as default (mine was nano?) and/or check $EDITOR. This took me longer to find than it should have. Thanks for the sweet tool.

from dnote.

@dvnrsn thanks for the feedback. By the way, it is defaulting to vi. I suspect that your system's $EDITOR was set to nano (I have noticed this in the past in some fresh ubuntu installations). Please let me know if otherwise. https://github.com/dnote/cli/blob/0a2413070f7167e020aabdebf9bc2e78082b0272/core/core.go#L78-L99

from dnote.

I'm fairly confident my $EDITOR was vim, but my dnote was out of date. Upgraded and good to go. :)

from dnote.

@dvnrsn great, thanks for the update.

from dnote.

I will close this for now due to inactivity. If anyone finds edge cases or have suggestions, please feel free to comment.

from dnote.