Comments (3)
There are three approaches. I propose option 2.
Option 1: Add upgradeInterval
to the config
upgradeInterval
is a milliseconds to be elapsed since the last upgrade check before checking for an upgrade again. Currently, this value is hard coded (https://github.com/dnote/dnote/blob/master/pkg/cli/upgrade/upgrade.go#L36). If the value is -1, Dnote will not check for upgrade.
Cons
- Relies on the magic value of
-1
which is hard to understand without consulting a doc.
Option 2: Add enableUpgradeCheck
to the config
enableUpgradeCheck
is a boolean value in the config that dictates whether upgrade check should be done. If false, Dnote will not check for upgrade.
Cons
- Does not allow the flexibility of configuring upgrade interval, as in option 1.
Option 3: Add upgradeInterval
and enableUpgradeCheck
to the config
To mitigate the con of option 2, this option mixes option 1 and 2.
Cons
- Adds complexity and violates the "Simple" tenet (https://github.com/dnote/dnote/wiki#tenets) (If, in some future, we realize that
upgradeInterval
is important to have, we can add it separately).
from dnote.
Created #646 as a request for comment.
TODO before release: add a doc.
from dnote.
Released in v0.15.0
from dnote.
Related Issues (20)
- How to install 32bits? HOT 1
- Internal Server Error When Syncing Notes HOT 1
- 403 when using dnote sync HOT 1
- Response 429 "Too many requests" again. HOT 1
- web interface HOT 1
- darwin_arm64 cli binary is broken? HOT 5
- Use OnPremises rather than OnPremise
- GPG encryption HOT 1
- Simplify by removing dependency on Cobra HOT 1
- homebrew install broken HOT 1
- How do I have dnote.exe on Windows connect to a dnote docker host? HOT 1
- Error relocating dnote, need musl(libc) release HOT 4
- Error: request() got an unexpected keyword argument 'chunked' HOT 1
- Autocompletion zsh script appears to be faulty HOT 2
- Glitch of chinese appearance in output of VIEW command HOT 3
- please provide an configuration option to change the location of dnote database HOT 1
- what about adding an option for simple auth for home server such as basic auth HOT 2
- Question: Find partial match HOT 1
- remove web interface part in makefile HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dnote.