Git Product home page Git Product logo

lokalise-key-push's People

Contributors

dmmikkel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

Forkers

moment-team

lokalise-key-push's Issues

Single language upload populates foreign-hosted languages

Hello, I've been using your action to automate uploading my English dictionaries to Lokalise but I have been experiencing an unexpected side effect with the plugin, I figured I'd start a conversation around it while I work towards finding a solution.

Problem Description

When the action is triggered, it's adding english values to the foreign dictionaries. This is inflating the dashboard view's translation counts, which our team uses as an indicator for when to place new translation orders.

Observed Behavior

As an action configured to upload only the english dictionary, when I'm triggered, I add any new keys I find to each language for a given Lokalise Project.

Desired Behavior

As an action configured to upload only the english dictionary, when I'm triggered, I add any new keys I find to only the english dictionary for a given Lokalise Project.

Supporting Evidence

Workflow file

# Github Actions Documentation: https://help.github.com/en/github/automating-your-workflow-with-github-actions

# Localisation Service:  https://lokalise.com
# Yaml File Source: https://github.com/marketplace/actions/lokalise-key-push
name: Push keys to Lokalise

on:
  push:
    # Only run workflow for pushes to specific branches
    branches:
      - master
    # Only run workflow when matching files are changed
    paths:
      - "locales/en/common.json"

jobs:
  upload:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - uses: dmmikkel/[email protected]
        with:
          # Api token for the Lokalise account
          # with read/write access to the project
          api-token: ${{ secrets.redacted }}

          # ID of the project to sync
          # Ref: https://lokalise.com/settings/redacted/
          project-id: redacted

          # The relative directory where language files will be found
          directory: locales/en

          # Which format to parse (json or properties)
          format: json

          # Which platform to push new keys to
          platform: web # or android, ios, other

          # The filename new keys should be attached to
          filename: common.json

Sample Tax Execution Log

 Run dmmikkel/[email protected]
Finished
Read language file /home/runner/work/redacted/locales/en/content.json
Found 546 keys in languge file for 'de'
Read language file /home/runner/work/redacted/locales/en/content.json
Found 546 keys in languge file for 'it'
Read language file /home/runner/work/redacted/locales/en/content.json
Found 546 keys in languge file for 'ja'
Read language file /home/runner/work/redacted/locales/en/content.json
Found 546 keys in languge file for 'ko'
Read language file /home/runner/work/redacted/locales/en/content.json
Found 546 keys in languge file for 'pt_BR'
Read language file /home/runner/work/redacted/locales/en/content.json
Found 546 keys in languge file for 'es'
Keys to push:
    syncUps::syncUpCreator
        zh_CN: <0>{{creator}}</0> <1>created a Sync-Up</1>
        en: <0>{{creator}}</0> <1>created a Sync-Up</1>
        zh_TW: <0>{{creator}}</0> <1>created a Sync-Up</1>
        fr_CA: <0>{{creator}}</0> <1>created a Sync-Up</1>
        fr_FR: <0>{{creator}}</0> <1>created a Sync-Up</1>
        de: <0>{{creator}}</0> <1>created a Sync-Up</1>
        it: <0>{{creator}}</0> <1>created a Sync-Up</1>
        ja: <0>{{creator}}</0> <1>created a Sync-Up</1>
        ko: <0>{{creator}}</0> <1>created a Sync-Up</1>
        pt_BR: <0>{{creator}}</0> <1>created a Sync-Up</1>
        es: <0>{{creator}}</0> <1>created a Sync-Up</1>
Pushing 1 new keys to Lokalise
Push done!
Finished

giphy

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.