dmeoli / ws4j Goto Github PK

Hi @DonatoMeoli
Thank you for your code!
I'm using the class SimilarityCalculationDemo and I noticed it returns 0 in all similarity algorithms for some words. For example, I've tested with (car, vehicle) and (cancer, disease).

I guess the problem is at
https://github.com/DonatoMeoli/WS4J/blob/008a427123a9f25106ea81495eb256976658dd1f/src/main/java/edu/uniba/di/lacam/kdde/ws4j/util/WordSimilarityCalculator.java#L110

It's necessary adding the code:
double score = relatedness.getScore(); if (score > maxScore) maxScore = score;

Do you think it is correct?

I found bug when i tried ws4j using token monitor-patient, i can't run demo using those token. I tried on your web demo, it works, but it error on eclipse.

Hello, it is possible to construct a Concept value, via the first constructor, which gives an object with no value for the pos field:

but code elsewhere that operates on Concept objects will assume that the pos field has been populated: which can result in a runtime exception.