Git Product home page Git Product logo

cats's People

Contributors

dmcardle avatar rwanthony avatar

Stargazers

 avatar

Watchers

 avatar

cats's Issues

note elimination

Testing

Please come up with some test code and documentation for your note elimination function because it is not clear to someone who is not the author of the code what it means or how it works If you made a unit test for this function (or attempted to test the function in any way), you would see that this code will not run because it is not indented properly. This is a basic function so it would be simple to write a unit test for it. Unit tests belong in unitTests.py, so do not create a separate file for this function.

Python Indentation

When I say that the indentation is incorrect, this is because the body of Python functions must be indented. Since Python has no begin and end tokens (curly braces in C languages, end in MATLAB), it relies entirely on indentation.

If a function is written this way, it is not clear where we should stop execution of myFunc. In this example, only y = 2 should be part of myFunc.

def myFunc(params):
y = 2
x = 1

To correct this, indent the lines that belong to the body of myFunc, like so.

def myFunc(params):
    y = 2
x = 1

File Organization

In MATLAB, the convention is one file per function, but in Python, many functions typically go in one file. Rather than making a new file for this function, I would recommend that you move (and edit) it so it is a member in the Transcriber class of file transcribe.py.

In the future, please make sure that code is runnable (it doesn't have to be correct, just make a note of that) before syncing your commits to this repository.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.