dkubb / dockerfiles Goto Github PK

The bundle command should not be run as the root user. After gem installation the files should be changed to be owned by root:root and have 0644 perms.

Currently its easy to introduce regressions like typos or syntax errors as just corrected in #25.

We want a minimal smoke test that:

• Builds all images on CI, that will cover the Dockerfiles can result in an image (not their correctness)
• Boots the images and hits / or another stable generic URL asserting a specific status code. This will cover the shipped nginx configuration is free from some easy to catch errors (such as typos)

While by far not perfect its much less likely we introduce "stupid" regressions with a most basic guard.

By adding --read-only to the docker run command, and specifying /var and /etc/service as being volumes, it should be possible to mount everything as read-only.

The only change should be for Rails to log to /var/logs so that it doesn't attempt to write to /opt/rails/logs, which will become immutable.

Currently the same stanza is duplicated between every bash script that enables a "strict mode" for the bash script to run under. It would be better for this to be globally available so that it can be included in every bash script instead of duplicated.

On some builds I see bundler related determinism problems. I suspect that upgrading the base image to shop the most recent bundler version may fix them.

Some of the functionality is shared between alpine-rails-buildkite and alpine-rails-nginx but not all. We have to explicitly remove rails and nginx references from alpine-rails-buildkite, which should not happen if there was a common shared container for both.

When a container is shut down it attempts to execute /etc/runit/3, but the file does not exist. A stub should be created to prevent this error.

If there is a simple way to shut down all running services started by /etc/runit/2 that would be preferable, but at the moment I do not know of one.