dkouzoup / ms-eetc Goto Github PK

I am not sure if this is a bug or just something that is really not obvious, but I have encountered some issues in modifying the simulation for figure5.

In what follows, I only talk about computations with static efficiency.

When running figure5.py, it appears that the static efficiencies \eta^{tr} and \eta^{rb} both concide and are specified by the variable etaMax on line 94 with value 0.73. I wanted to change it to the pair of efficiencies \eta^{tr} = 0.875 and \eta^{rb} = 0.7 found in the train model file NL_Intercity_VIRM6.json.

So what I did is that in line 97 (definition of fun1), I have changed the values of etaMax to two literals, e.g. fun1 = lambda f,v: f*v*(f>0)*(1 - 0.875)/0.875 - (1-0.7)*f*v*(f<0), where essentially \eta^{tr} = 0.875 and \eta^{rb} = 0.7. Strangely enough, on the generated plots, the consumption values were exactly the same in almost all runs. In the following I provide an enumeration of these results:

• \eta^{tr} = \eta^{rb} = etaMax = 0.73: 151.1 / 124.6 / 111.8 / 106.4 kWh (figure5_eta_max.pdf)
• \eta^{tr} = 0.875, \eta^{rb} = 0.7: 151.1 / 124.6 / 111.8 / 106.4 kWh (figure5_mixed_eff_875_700.pdf)
• \eta^{tr} = 0.001, \eta^{rb} = 0.001: 151.1 / 124.6 / 111.9 / 106.5 kWh (figure5_almost_zero.pdf)
• \eta^{tr} = 1, \eta^{rb} = 1: 151.1 / 125.9 / 112.5 / 106.4 kWh (figure5_perfect.pdf)

These show that the consumptions are barely sensitive to the change in efficiency. However if I comment out line 134, thus forcing the program to use the line powerLosses = lambda f,v: f*v*(f>0)*(1 - self.etaTraction)/self.etaTraction - (1-self.etaRgBrake)*f*v*(f<0) (line 203 in train.py) to define the power losses (i.e. the \eta^{tr} and \eta^{rb} from the train model file), then the consumptions become

• 151.1 / 120.6 / 107.6 / 100.9 kWh (figure5_bypass.pdf), which now completely coincide with those of the dynamic efficiency. So this makes me think that in this case we run with dynamic efficiency.

There is either a bug here or I severely misunderstand how the program processes static efficiencies. How can I run figure5.py while configuring arbitrary etaTraction and eta RgBrake?

• currently only static efficiency is imported from the train specs in json
• we should allow import of dynamic efficiency (defined in terms of efficiency or power losses
• we should treat the case where no efficiency data are available in the json file (default values?)

• add readme.md files in trains/ and tracks/ explaining the json files and the configurations (passed to constructors)
• explain OCP options