dkoppel / tech-challenge Goto Github PK

I started with tagging all resources consistently, and then lost track of it mid development, leaving me with inconsistently tagged resources. I caught a snippet in the docs of a default_tags parameter and need to dive deeper and clean up the tags.

The terraform configuration currently will never get to a "satisfied state", it always has one lingering change or replacement in a loop.

It wants to recreate aws_autoscaling_attachment.app_attachment, and then update aws_autoscaling_group.app_asg, alternating between the two states each run, with auto scaling instances falling out of the target group after the autoscaling group is updated in place.

This may be resolved by reworking the launch template for #1, however I'm not certain.

I'm currently using a deprecated launch configuration rather than the recommended launch template. Fix this.

This configuration currently relies on manual key generation prior to applying the configuration. It feels clunky, but I wasn't able to quickly ascertain the right way to generate and locally store private keys in Terraform, and didn't want it to block the rest of my work. I started down a path of investigating how to output sensitive fields on the CLI, but decided to err on the side of secure, user managed keys for this proof of concept. If I have time I would revisit this and look into securely storing the key in SSM or locally.

I'm not super happy with the layout of the working configuration, and would like to do more work to clean it up and make it presentable.