Git Product home page Git Product logo

libfasta's People

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

libfasta's Issues

fasta_read() return type is bool, not FASTA_rec_t*

I'm trying to compile your project here, but there is the most bizarre issue that I though I should message you before going down any rabbit holes. It appears that at compile time, fasta_read() returns type bool, despite the declaration in fasta.h being of type FASTA_rec_t*. Do you have an idea why this might be?

g++ -g -Wall -pipe -lfasta -lpthread --std=gnu++0x main.cpp -o mummer
main.cpp: In function ‘globalArgs parseArgs(int, char*)’:
main.cpp:229:25: error: cannot convert ‘bool’ to ‘FASTA_rec_t
’ in assignment
while(tmpFastaRecord = fasta_read(inFile, NULL, 0, NULL) != NULL){

Address CPU and memory overhead

With the addition of more debugging resources and an improved bwt construction, I've tracked issues to the FASTA file opening, which actually takes up ~20 minutes and 8GB before segfaulting when loading human chromosome 2. I'm not sure where in the library this is yet, but that's the usage issue.

Need to start looking into the fasta_open() codepath.

Unclear location of sequence descriptor strings

Throughout the code, there is not a whole lot of documentation. For FASTA_req_t, seq could have new lines or not from a reading of the documentation, but this is easy to find for certain. What isn't is where the description strings are located. The header sections appear to hold indexing information and not any form of description strings. I can't be sure however, as the documentation is not complete enough.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.