dividab / abstract-visuals Goto Github PK

In abstract-image ramda is used:

https://github.com/dividab/abstract-visuals/blob/master/packages/abstract-image/src/exporters/react-svg-export-image.tsx#L1

However in package.json dependencies it is not listed:

https://github.com/dividab/abstract-visuals/blob/master/packages/abstract-image/package.json#L17

Vnom becomes a different atom and the logic in abstract-document/src/abstract-document-exporters/pdf/render.ts ln 204-213 causes it to line break

Trying to create

[ image symbol ] Explanation of symbol

but get them as

[ image symbol ]
Explanation of symbol

even though there is more than enough space to fit both on the same line.

Currently work around this by creating a table and putting them in different cells, but feel unnecessarily complicated.

Improve the tests

It is currently not particularly informative/helpful.

Add rotation property for binaryimage.

Missing tests for:

• abstract-image
• markdown
• abstract-document-exporter/pdf/render-image
• abstract-document-exporter/pdf/pre-process

Abstract-document currently hardcodes the compression flag to "false".
It would be a good idea to allow changing this flag, possibly through an optional options argument to exportToStream.

https://github.com/dividab/abstract-visuals/blob/master/packages/abstract-document/src/abstract-document-exporters/pdf/render.ts#L39

This is an issue if you want tables and columns to be a specific size, but word combines them when they are placed directly after each other.

Seems like packages/abstract-document/src/abstract-document-exporters/pdf/render-image.ts line 117 doesnt consider the fontWeight option

Would work similarly to how columnSpan works but for spanning over rows instead

I would need to be able to add LineThrough styling for texts in abstract-document:

Example of what I need

Until alafr/SVG-to-PDFKit#152 is resolved it would be good to create a work-around on our end to allow for uppercase letters in the color definitions.

e.g. fill="Red" needs to work, not just fill="red".

Setting a table cells border to any value bigger than 1 doesnt increase the width of the border.

https://pdfkit.org/docs/text.html#text_styling
baseline - the vertical alignment of the text with respect to its insertion point (values as canvas TextBaseline)

Currently fromString only supports entering ARGB values.
It would be nice to also support RGB values, setting the alpha channel to 255.

I wish to be able to set the color of each border of a cell separately instead of having just one color for them all.

If the y-axis values are too long they will collide with the y-label (see image for exaple). Could the y label positioning be dynamically decided?

There seems to be a memory issue when rendering a chart with large delta value for any of the axis.

Example:

import * as AbstractChart from "abstract-chart";

const chart: AbstractChart.Chart = {
  width: 500,
  height: 500,
  chartPoints: [],
  chartLines: [],
  chartStack: {
    points: [],
    config: [],
    xAxis: "bottom",
    yAxis: "left"
  },
  xAxisBottom: {
    type: "linear",
    min: 0,
    max: 1000000,
    label: ""
  },
  yAxisLeft: undefined,
  yAxisRight: undefined,
  xAxisTop: undefined,
  backgroundColor: {
    a: 255,
    r: 255,
    g: 255,
    b: 255
  },
  gridColor: {
    a: 255,
    r: 128,
    g: 128,
    b: 128
  },
  gridThickness: 1,
  fontSize: 12,
  labelLayout: "center"
};

AbstractChart.renderChart(chart);

All pages follows the same orientation. Pages that are supposed to deviate to this is not working, content is outside of page

Not a very frequent/urgent issue since few texts are that long, but still something that is not working.

In the example below we have a header, a footer, and a body each with 50 margin. The body consists of one paragraph containing multiple textruns.
The paragraph over-runs both the 50+50 margin between body and footer, and the footer text.

As a future addition this allows us to add repeatable headers

The readme says:

When drawing complex scientific charts, regular line/bar/pie chart libraries are not very useful. This aim of this library is to enable any chart to be drawn, no matter how complex

Stating that bar and pie charts would be possible with this library, however there is no clear way of creating these in abstract chart.

I managed to make this using the current functionality of abstract-chart:

However, as far as I know,

1. there's no way to set the fill colour of the pie slices
2. there's no way to hide the axis completely
3. the ChartPoint's label is weirdly offset
4. the pie gets squished even though both width and height is set to 400.

I believe DIAQ has implemented coloured areas locally, so that could be used as reference.

As for bar charts, I believe they suffer the same problems as above.

It would also be quite nice to have examples of a pie chart and bar chart to ease development for other devs looking to use this library.

If the last row fits on the page but the table doesn't fit due to the margin after the last row, then the split results in empty elements that causes an exception.
Logic needs to take table top/bottom margins into account.

The split table should keep top margin for upper table part while setting bottom to 0, and reverse for lower table where top should be 0 and bottom be kept.

https://github.com/diegomura/react-pdf

This is very close to the abstract-document idea.

When selecting other formats than A4, the dimensions of the Docx page is not parsed, and when opening the document in Word it will display values as for A4.

The text seems to be split up in 3 parts

This is the plain text:

## FAN MOTORS
The AC fans are axial type, 800 [mm] diameter, IP54 grade and equipped with a thermal overload protection. They are also fitted with protection grids on top.

We are missing tests for the following recent functionality:

• Support for custom font in abstract-chart
• Support for binaryimage with URL in abstract-image
• Support for positioning and scaling embedded images in abstract-image

Also missing entries in CHANGELOG.md.

After the change to use lowerCase for fill/stroke/color even in-svg definitions went to lowerCase and do no longer match, e.g. fill="url(#Pattern)"

Suggesting exception to lowerCase if the string contains url.

(This will likely cause problems if anyone uses the namedColor burlywood and spells it with upperCase, but since this is not intended to be a long term solution but only while alafr/SVG-to-PDFKit#152 isn't fixed, that drawback feels acceptable to me.)