Returning a 204 response without a content-length is breaking Safari & IE uploads. Just add 'Content-Length' header with value '0' to the response.

Would it be easy to make the library compatible with Django 2.x?

Hello,

Using tus-js, I tried to upload a "big" file (like 630Mo), with a chunk size of ~100485760 bytes. During the upload, I have closed my browser.

Expected behaviour : the file is partially written into /tmp, the Upload-Offset field is set at the number of bytes actually written.

Actual behaviour : the file is partially written into /tmp, the Upload-Offset field is set at the number of chunks processed times the size of a chunk.

In my tests, I have stopped the upload during the third chunk. I have 1004857602+67813376 = 268784896 bytes written on the filesystem whereas my Upload-Length in database is 1004857603 = 301457280 bytes.

In django settings I have configured:
FILE_UPLOAD_MAX_MEMORY_SIZE = 162144000
DATA_UPLOAD_MAX_MEMORY_SIZE = None

I tried to track down the issue and it seems that the issue lies in the models.py file:

` def write_data(self, bytes, chunk_size):
write_bytes_to_file(self.temporary_file_path, self.upload_offset, bytes, makedirs=True)

    self.upload_offset += chunk_size
    self.save()

`
Here, the chunk_size assumes that the chunk is totally uploaded. In my tests, it looks like I get the correct upload_offset value using len(bytes) whereas than chunk_size for the update for upload_offset but I don't know if that could cause other issues, or if I missed something.

Is there any reason to not use len(bytes) ?

Regards,
Grégoire

Looks like the doc website is not depolyed with the last version.
See
https://drf-tus.readthedocs.io/en/latest/usage.html

• Django version: 3.2
• Python version: 3.10
• Operating System: Linux

Description
I am using drf-tus in django. i am getting KeyError while uploading from android-tus-client on the on the other hand tus-js-client is working fine. I don’t understand why am getting this error because the drf-tus is working fine with tus-js-client except android-tus-client.

I have try to upload files using android-client and tus-js-client they both are working fine with tusd server, but when is try to upload file using drf-tus in django the android-client is getting keyError on get_chuck() because the android-client is sending Transfer-Encoding": "chunked" and chuck data is b"" header on the other hand the js-client is working only

I want to upload file from android and js-clients as well but android is not working for me. Please help me on it.

DRF_tus partial_update print header is while uploading from tus-js-client

    "Content-Length": "152944",
    "Content-Type": "application/offset+octet-stream",
    "Connection": "keep-alive",
    "Tus-Resumable": "1.0.0",
    "Upload-Offset": "0"

DRF_tus partial_update print header is while uploading from android-tus-client

    "Content-Length": "",
    "Content-Type": "application/offset+octet-stream",
    "Tus-Resumable": "1.0.0",
    "Upload-Offset": "0",
    "Expect": "100-continue",
    "Transfer-Encoding": "chunked"