dipeshrai123 / react-ui-animate Goto Github PK

• Issue replication: While creating a Modal and using the useOutsideClick hook to handle the dismiss on outside click when we click on the open button the modal doesn't appear. It is as soon as we click the open modal button the outside click callback is instantly fired which causes the issue

Work on branch: fix/useOutsideClick from base v2.0.0
Create a PR against it after completing the issue with the solved video output.

Issue:

• In v2, animated value doesn't have type, Instead we use ValueType while assigning the value.

Expected Result:

• Type should be added for animated value

A possible snippet could be :

useDisableScroll = (shouldDisable: boolean) => {
  React.useEffect(() => {
    document.body.style.overflow = shouldDisable ? 'hidden' : 'auto'
  }, [shouldDisable])
}

• from: 0
• enter: 1
• exit: 0

useMountedBlock hook on false state unmounts the component immediately without any transition.

Issue:
Currently, MountedBlock and TransitionBlock are separate components.

Expected Result:
MountedBlock and TransitionBlock should be merged into one HOC. It lets devs to use same component whatever the use-case. You might want to use the prop to determine whether the component has to be mounted or not. Please make sure to use the prop names more sensible and short

Possible snippet:

export function useMountedValue(state: boolean, config: UseMountConfig) {
  const mv = useMount(state, config);
  return (
    cb: (value: { value: FluidValue }, mounted: boolean) => React.ReactNode
  ) => mv((a, m) => cb({ value: a }, m));
}