dinhoabreu / codes Goto Github PK

It seems that when an input string ends with a double-quote character ("), that character is not correctly converted to UTF-7. There are probably other affected characters (at a guess, all the characters outside the set of UTF-7 direct characters), but this is the one that tripped me up.

Here is a test case to demonstrate the issue:

var codes = require('codes');
var input = '"test"';
var expect = '+ACI-test+ACI'; // obtained with `echo '"test"' | iconv -f utf8 -t utf7` using iconv (Ubuntu EGLIBC 2.11.1-0ubuntu7.12) 2.11.1
//var expect = '+ACI-test+ACI-'; // obtained using node-iconv 2.0.7
var from = 'utf8';
var to = 'utf7';
var conv = codes.create(to, from);
var input_buf = new Buffer(input, from);
var output_buf = conv.convert(input_buf);
var output = output_buf.toString('ascii');
console.log(expect, input, output);

Using codes 0.2.4, the output variable ends with "+AC" when it should end with "+ACI" or "+ACI-". I experimented with the various conversion methods to see if there was a specific code path that was causing this, but even calling the C binding directly produces the same truncated result.