dimidimit / custom-lan Goto Github PK

When attempting to load any singleplayer worlds, The safe mode button automatically gets shown but when you try to create new worlds instead; the client will just crash.

Crashes when opening the singleplayer
crash-2021-08-09_17.49.19-client.txt

So, this mod reaaaaally helps out when used with ESSENTIAL, and simple voice chat, because everytime you open LAN, the port always changes, but with custom LAN, voicechat keeps the same port so there is no need for tweaking the config files everytime

but I prefer using Ngrok LAN because for some reason is less laggy and buggy than essential, the only downside being the forever changing port, but Custom LAN is not compatible with Ngrok LAN (crashes when opening the OPEN TO LAN menu), and is the most convinient way to use simple voice chat, so finding a way to pair Ngrok with custom lan would be really cool

maybe it doesnt work because of how ports work n stuff but idunno about that stuff, wouldnt hurt to try tho, if it worked with essential, why wouldnt it work with Ngrok

Whenever the no-chat-reporting mod is installed or not iirc, opening the "Edit LAN" button will cause it to re-direct to the player reporting page instead since 1.19.1,

Originally this issue went to #100 but decided to re-direct it here to see if it possible to have the two buttons resolved since other dev explained that it isn't their issue.

It would be awesome cause there are no 1.17.1 mods with such option for casual non-techy guys

So, after updating to [1.20-1.20.1] Custom LAN 2.3.0 after quitting the world, it always takes about 2 minutes to save it. Moreover, it doesn't depend on whether I did something in this world by loading chunks maybe or I immediately left it.
I looked at latest.log after leaving my main and test world. Every time at the end of the logs, I see an error pointing to your mod:

[21:12:14] [Server thread/INFO]: ThreadedAnvilChunkStorage (Test): All chunks are saved
[21:12:14] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[21:12:14] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[21:12:14] [Server thread/INFO]: ThreadedAnvilChunkStorage (otherside): All chunks are saved
[21:12:14] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[21:12:14] [Server thread/INFO]: closing rrp ebe:base_resources
[21:12:14] [Server thread/ERROR]: Exception stopping the server
java.lang.NullPointerException: Cannot invoke "com.dimitrodam.customlan.TunnelType.stop(net.minecraft.server.MinecraftServer)" because the return value of "net.minecraft.server.MinecraftServer.getTunnelType()" is null
	at net.minecraft.server.MinecraftServer.handler$cgj000$customlan$postShutdown(MinecraftServer.java:5313) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_3782(MinecraftServer.java:619) ~[client-intermediary.jar:?]
	at net.minecraft.class_1132.method_3782(class_1132.java:209) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:703) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265) ~[client-intermediary.jar:?]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
[21:12:14] [Server thread/INFO]: [FastQuit] The world "Test" has been successfully saved. (1min 46s)
[21:12:14] [Render thread/INFO]: closing rrp ebe:base_resources

Apart from this error, everything works fine and I don't see any problems in the latest.log.
Moreover, this error occurs despite the fact that I didn't even open the world to the LAN. That is, I can literally enter the world, immediately exit it, and I still have to wait almost 2 minutes until this error is apparently forcibly terminated.
And yes, with version [1.20-1.20.1] Custom LAN 2.2.3 this error didn't occur.

I changed the config file and added a token between "" but it didn't change anything. Then I restarted minecraft and tried to use tunnels again and minecraft just crashed (it looks like something that might help https://mclo.gs/QjMgKUt ) I have no idea what else can be done to make the mod see authtoken

Thank you for your help

Hi,

I accidentally found your repo. Looks like we are working on a very similar concept.

https://github.com/rikka0w0/LanServerProperties

What do you think about working together at some point? My implementation supports both Forge and Fabric. It uses Mojang mapping. I have created a thin abstraction layer to isolate the difference of the mod loaders and underlying APIs. Most code only needs to be written once.

Regards,

The mod appears to function just fine on 1.19.2. Easy update!

/src/main/resources/fabric.mod.json

-     "minecraft": ["1.19.1"]
+     "minecraft": ["1.19.1", "1.19.2"]

I'm playing on 1.16 with the Mod Menu mod, which adds an extra button to the pause menu. It seems this it messes with the button order and this mod disables the wrong one, because when I'm playing on a server with it I can't access either my options nor the LAN menu.

When attempting to load up any world in 1.18.2 - The mod will just crash with mixins + refmaps being broken.

The pastebin where the crash dump is stored to.

As title says it - However in 1.19.4, The port can now be changed directly in vanilla instead of having to use this mod for it instead.

Likely going to assume 1.20.1 may be doable aswell as it's currently similar to this version itself.

If possible in a future release could you add an option to auto-load per world settings and open the world to LAN automatically when the world is started.

I want to be able to host my LAN game to my friends and not bother them with installing any of my mods. However, it doesn't let other players join the game without Custom LAN installed: