/

Thanks for the packages but I can't seem to get the Basic Auth running properly...

The xml config file $TOMCAT_HOME/conf/Catalina/localhost/vefa-srest.xml is not being created when deploying the WAR.
Creating it manually then gives the following error at startup:

FAIL - Application at context path [/ringo-server] could not be started
FAIL - Encountered exception [org.apache.catalina.LifecycleException: Failed to process either the global, per-host or context-specific context.xml file therefore the [/ringo-server] Context cannot be started.]

In ringo-tomcat-realm/pom.xml there is a dependency on no.sr.ringo:ringo-security, which can not be satisifed.

The /statistics resource fails with ORA-00933: SQL command not properly ended when using Oracle.

This is because the SQL string includes a statement terminator. Unsure if this also is a problem on other databases.

If PeppolMessageRepositoryImpl is changed from this:
final String orderBy = "\nORDER BY account.name ASC; ";
to this:
final String orderBy = "\nORDER BY account.name ASC";
it works on Oracle.

See http://www.mkyong.com/maven/how-to-download-javamail-api-from-maven/

Currently when getting /messages//xml-document the result only contains the SBD payload and the containing SBD and SBDH is removed.
If would be useful if this behaviour was configurable.

As Oxalis have been completely rewritten in v4.x and this project has not been updated since 2017 I wonder if it will work with Oxalis 4.0.2 ?

SQL defined as:
String sql = "insert into outbound_message_queue_error (queue_id, details, message, stacktrace) values (?, ?, ?, ?);";
The SQL string should not end with the SQL terminator.

The SQL query that selects the number of inbound messages eligible for the /inbox resource, contains criteria, which are not portable to other databases like for instance Oracle.

Furthermore, all messages shall have a message_uuid henceforth there is no need for any criteria on this column.

select count(*) from message where account_id=1 and direction= 'IN' and delivered is null and message_uuid is not null and message_uuid != ''

I get a "You do not have access to view this resource." message after giving the Basic Auth login.
I am running on a separate server (not localhost).

There are no errors in the logs apart from the below after trying to access the ringo-server

11-Mar-2018 18:02:45.494 SEVERE [main] org.apache.tomcat.util.descriptor.web.SecurityConstraint.findUncoveredHttpMethods For security constraints with URL pattern [/admin/*] only the HTTP methods [GET] are covered. All other methods are uncovered.
11-Mar-2018 18:02:45.494 SEVERE [main] org.apache.tomcat.util.descriptor.web.SecurityConstraint.findUncoveredHttpMethods For security constraints with URL pattern [/register/*] only the HTTP methods [POST GET] are covered. All other methods are uncovered.
11-Mar-2018 18:02:45.494 SEVERE [main] org.apache.tomcat.util.descriptor.web.SecurityConstraint.findUncoveredHttpMethods For security constraints with URL pattern [/*] only the HTTP methods [HEAD DELETE POST GET PUT] are covered. All other methods are uncovered.
11-Mar-2018 18:02:52.705 INFO [main] org.apache.catalina.core.ApplicationContext.log ContextListener: contextInitialized()
11-Mar-2018 18:02:52.712 INFO [main] org.apache.catalina.core.ApplicationContext.log SessionListener: contextInitialized()
11-Mar-2018 18:02:52.713 INFO [main] org.apache.catalina.core.ApplicationContext.log ContextListener: attributeAdded('StockTicker', 'async.Stockticker@4b91ac30')

sr [11/Mar/2018:19:37:22 +0000] "GET /ringo-server/ HTTP/1.1" 404 44

mvn clean install should work on a blank machine.

Integration tests requiring certificates, internet connection etc. should be activated by a profile.

When excluding tests by including them in an excluded group, remember to also include the @BeforeXxx annotated methods.

Have been testing vefa-srest with Oracle 12c as database.
For instance POSTing to /outbox fails with a java.lang.NumberFormatException because Oracle returns generated keys differently than for instance mysql.

Have been able to POST to /outbox after changing this a little.
Instead of code like this which is used today:
PreparedStatement insertStatement = connection.prepareStatement(INSERT_INTO_MESSAGE_SQL, Statement.RETURN_GENERATED_KEYS);

I used something like this:
PreparedStatement insertStatement = connection.prepareStatement(INSERT_INTO_MESSAGE_SQL, new int[] {1});

Changed this in MessageRepositoryH2Impl.createMetaDataEntry and QueueRepositoryImpl.putMessageOnQueue to get POST /outbox to work.

I have not tested if this change also works on other databases. If it works for other databases as well, this change must be made more places than I have listed in the examples above.

The SQL being executed when performing http GET on /statistics gives syntax error in Oracle and MS SQL Server.

1. Using SUM() for counting gives wrong results
2. Current use of logic predicates inside the aggregate functions is considered invalid by many systems.
3. The GROUP BY fails.