Git Product home page Git Product logo

seeded-crypto-ios's People

Contributors

angelix avatar bakhtiyork avatar uppajung avatar

Watchers

 avatar  avatar  avatar  avatar

seeded-crypto-ios's Issues

Fix naming consistency

For consistency between SymmetricKey and UnsealingKey, change
SymmetricKey.unsealJsonPackagedSealedMessage() -> SymmetricKey.unseal(withJsonPackagedSealedMessage: packagedSealedMessageJson)

Also, for all objects that support serialization, if possible change:
.fromSerializedBinary(from: ... )n -> .from(serializedBinaryForm: Data)
.fromJson... ->. .from(json: String)

Exceptions handling

Swift seems unaware that a number of operations that could throw exceptions might throw them.

For example, when I call unseal operations, those operations should throw an exception if the PackagedSealedMessage contains an invalid ciphertext. When I put "try" before that operation in Swift, it says that unsealing can't result in an exception.

SeededCrypto library should work with messages/plaintext that contains raw data

Please update the Objective C/ C layer to allow all fields named "message" to be passed as NSData (ObjectiveC) / Data (Swift) type as an additional option to the current type of NSString / String. (do not remove the current versions that take String as a parameter)

  • DSCSealingKey.sealWithMessage, parameter message (4 calls total)
  • DSCUnsealingKey - all instances of message
  • SignatureKey - all instances of message
  • SignatureVerificationKey - all instances of message
    -DSCSymmetricKey, all instances of parameter message (which should be plaintext for consistency?)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.